Simplify AppBuilder tool initialisation (#47)#202
Draft
leynos wants to merge 1 commit into
Draft
Conversation
Extract media tool configuration resolution and builder tool gating from `AppBuilder::init_tools` so the startup phase keeps shallow control flow. Reuse the shared bootstrap image and vision registration helper to avoid maintaining duplicate registration wiring in the composition root.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch simplifies
AppBuilder::init_toolsfor issue #47 by moving media tool credential and model resolution into a private helper, replacing duplicate image and vision registration wiring with the shared bootstrap helper, and naming the builder-tool registration predicate.Closes #47.
Review walkthrough
resolve_media_tools_configandshould_register_builder_toolhelpers.AppBuilder::init_toolsbody in src/app.rs to confirm the media and builder registration flow remains behaviour-preserving.Validation
coderabbit review --agent: passed with 0 findings.make all: passed format checks, clippy, GitHub WASM tool build, 4,146 nextest tests, and 5 GitHub tool tests.Notes
No public APIs changed. The branch deliberately keeps the refactor inside the application composition root and reuses the existing
MediaToolsArgsandregister_image_and_vision_toolsbootstrap API.