Group trace LLM test string arguments (#46)#203
Draft
leynos wants to merge 1 commit into
Draft
Conversation
Introduce typed expectation/specification structs for trace LLM test helpers so related string values are passed as named data rather than loose positional parameters. Keep the replay semantics unchanged while reducing the string-heavy function argument ratio reported for the support unit tests.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
github-actions
Bot
added
size: M
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch groups trace LLM unit-test helper arguments into named expectation and specification structs so CodeScene no longer sees the module as string-heavy. The change keeps replay behaviour unchanged while making related helper inputs harder to misorder.
Closes #46.
Review walkthrough
TextStepSpecfixture API used by the trace LLM tests.Validation
cargo test --test support_unit_tests trace_llm_tests: passed, 10 tests.coderabbit review --agent: passed, 0 findings.make all: passed, including formatting, Clippy, 4,146 nextest tests, and 5 GitHub tool tests.git diff --check: passed.