📝 CodeRabbit Chat: Implement requested code changes

[coderabbitai]

Code changes was requested by @leynos.

• Complete 1.1.4 hosted-mode tests: fidelity, routing, parity (refactor) #57 (comment)

The following files were modified:

• src/worker/api/types.rs

Summary by Sourcery

Add tests to validate remote tool API routes and serialization behavior between worker and orchestrator.

Tests:

• Add unit test to ensure worker and orchestrator share the same remote tool catalog and execute route patterns and placeholder expansion.
• Add round-trip JSON serialization tests for remote tool catalog responses to ensure tool metadata and instructions are preserved.
• Add round-trip JSON serialization tests for remote tool execution requests to ensure tool name and parameters are preserved.
• Add round-trip JSON serialization tests for remote tool execution responses to ensure tool output fields, cost, raw content, and duration are preserved.

[coderabbitai]

Important

Review skipped

This PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 5d5aafa7-393f-4aec-8afd-7a0fe6754d5c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sourcery-ai]

Reviewer's Guide

Adds unit tests to validate remote tool API route constants and JSON serialization round-trips for remote tool catalog, execution requests, and execution responses in the worker API types module.

Sequence diagram for JSON round-trip serialization tests

sequenceDiagram
    actor Test as TestRunner
    participant Catalog as RemoteToolCatalogResponse
    participant ExecReq as RemoteToolExecutionRequest
    participant ExecRes as RemoteToolExecutionResponse
    participant Serde as SerdeJSON

    Test->>Catalog: construct_instance
    Test->>Serde: to_string(Catalog)
    Serde-->>Test: json_catalog
    Test->>Serde: from_str(json_catalog)
    Serde-->>Test: deserialized_catalog
    Test->>Test: assert_fields_equal(Catalog, deserialized_catalog)

    Test->>ExecReq: construct_instance
    Test->>Serde: to_string(ExecReq)
    Serde-->>Test: json_exec_req
    Test->>Serde: from_str(json_exec_req)
    Serde-->>Test: deserialized_exec_req
    Test->>Test: assert_fields_equal(ExecReq, deserialized_exec_req)

    Test->>ExecRes: construct_instance_with_ToolOutput
    Test->>Serde: to_string(ExecRes)
    Serde-->>Test: json_exec_res
    Test->>Serde: from_str(json_exec_res)
    Serde-->>Test: deserialized_exec_res
    Test->>Test: assert_fields_equal(ExecRes.output, deserialized_exec_res.output)

Loading

Flow diagram for remote tool route constant validation test

flowchart TD
    A[Test initializes test_job_id] --> B[Test reads REMOTE_TOOL_CATALOG_ROUTE]
    B --> C[Test reads REMOTE_TOOL_EXECUTE_ROUTE]
    C --> D[Test asserts REMOTE_TOOL_CATALOG_ROUTE equals /worker/{job_id}/tools/catalog]
    D --> E[Test asserts REMOTE_TOOL_EXECUTE_ROUTE equals /worker/{job_id}/tools/execute]
    E --> F[Test replaces {job_id} in REMOTE_TOOL_CATALOG_ROUTE with test_job_id]
    F --> G[Test replaces {job_id} in REMOTE_TOOL_EXECUTE_ROUTE with test_job_id]
    G --> H[Test asserts expanded catalog route equals /worker/test_job_id/tools/catalog]
    H --> I[Test asserts expanded execute route equals /worker/test_job_id/tools/execute]

Loading

File-Level Changes

Change	Details	Files
Add tests ensuring worker/orchestrator remote tool routes and job_id substitution remain stable.	Introduce a test module under cfg(test) in the worker API types file. Assert the catalog and execute route constants match expected orchestrator route strings. Verify job_id placeholder substitution in the route constants produces the expected concrete paths.	src/worker/api/types.rs
Add JSON round-trip tests for remote tool catalog response to ensure no field loss.	Construct a representative RemoteToolCatalogResponse with nested ToolDefinition parameters and UTF-8 content. Serialize to JSON and deserialize back with serde_json. Assert that tools, descriptions, parameters, toolset instructions, and catalog_version are preserved exactly.	src/worker/api/types.rs
Add JSON round-trip tests for remote tool execution request and response types.	Create a RemoteToolExecutionRequest with structured params and verify equality after serde_json serialize/deserialize. Create a RemoteToolExecutionResponse using ToolOutput::success with duration, cost, and raw fields populated. Assert that result, params, cost, raw, and duration fields survive the round-trip unchanged.	src/worker/api/types.rs

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}