📝 CodeRabbit Chat: Implement requested code changes - #172
Open
coderabbitai[bot] wants to merge 12 commits into
Open
📝 CodeRabbit Chat: Implement requested code changes#172coderabbitai[bot] wants to merge 12 commits into
coderabbitai[bot] wants to merge 12 commits into
Conversation
`rust_consume_stream` is shipped, public in `cuprum/_streams_rs.py`, tested, and documented, yet no production code routes a consume through it — unlike the pump side, which has a `_pump_stream_dispatch` with a Rust-then-Python fallback. ADR-002 frames consume-routing as deferred, evidence-gated Phase 2 work (after the Phase 1 measurement schema), so the symbol's status was ambiguous to readers. Of the two resolutions the issue offers, take the annotation path — wiring a `_consume_stream_dispatch` now would bypass the ADR's measurement gate: - Annotate `rust_consume_stream` (module and function docstrings) as "implemented but not yet integrated", pointing at ADR-002 Phase 2. - Reflect the status in `docs/users-guide.md` so the private API is not mistaken for a wired bridge. - Record the decision in `docs/adr-002-additional-rust-components.md` under the Phase 2 heading. - Add a guard test asserting the docstring carries the marker and that no production module references the symbol; wiring the dispatcher later must remove the marker and the guard together.
Record the tee hot-path baseline findings in the rust consume-stream component documentation. Keep the current branch's annotation intact: `rust_consume_stream` is implemented and tested, but production dispatch must still wait for the Phase 2 dispatcher, fallback path, and parity property tests. Clarify the design diagrams and backend-selection text so they no longer imply that stdout or stderr consumption is routed through Rust today.
Clarify that the tee profiling baseline provides hotspot evidence for Phase 2, not acceptance of the consume dispatcher. Keep the 20% median wall-time gate tied to a future Rust-versus-Python dispatcher benchmark.
Use a NumPy-style `Notes` section for the `rust_consume_stream` status note, keeping the helper documentation consistent with the rest of its docstring. Switch the not-integrated guard from raw text matching to AST symbol reference detection so comments and docstrings do not create false positives when checking production modules.
Split the consume-stream status guard so the docstring marker and the production-reference scan are checked independently. Add maintainer documentation for the current `rust_consume_stream` state: it is implemented, tested, and exported, but production consume dispatch remains deferred to ADR-002 Phase 2 until dispatcher wiring, Python fallback, and parity/property coverage land.
Add roadmap phases 5-8 translating the tee hot-path profiling baseline and the issue #90/#127 follow-up into outcome-oriented work: - Phase 5 lands the Rust-free wins first (read-size plateau bump and lean per-line observe-hook emission) so the consume dispatcher must beat a tuned Python baseline. - Phase 6 hardens the PyO3 boundary (#90), establishes the 20% wall-time acceptance gate, wires _consume_stream_dispatch, and records the outcome. - Phase 7 scopes raw-sink echo/tee acceleration, profiling first to exclude kernel-bound PTY cost. - Phase 8 collects deferred reliability work (Rust pump FD close race, perf frame attribution) and the native-orchestration go/no-go decisions. Each phase carries a falsifiable GIST idea; tasks cite ADR-002, the design doc, the profiling baseline, and the relevant issues. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Handle AST scan read and parse failures explicitly in the production reference guard, and add coverage for invalid candidate modules. Update the consume-stream documentation to use current `echo=True` terminology and clarify that only pump-side routing has Rust backing today.
Replace the awkward consume-routing wording in ADR-002 and tighten the design guide so it says final stream consumption still uses the Python path until the Phase 2 consume dispatcher is wired and tested.
Avoid implying that a consume dispatcher is already wired for line-callback streams. State that stream consumption stays on the Python pathway until the Phase 2 consume dispatcher exists.
Use the specific module-reference scan error in the guard test and tighten the consume-stream documentation wording. Expand the consume-dispatch roadmap gate so it covers fallback regressions, parity before routing, and outcome-specific documentation dependencies.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Sorry @coderabbitai[bot], you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
Author
|
Important Review skippedThis PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
lodyai
Bot
force-pushed
the
issue-127-consume-stream-dispatch
branch
from
June 23, 2026 22:29
d104210 to
382d120
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code changes was requested by @leynos.
The following files were modified:
cuprum/unittests/test_rust_streams.py