docs: mark #125 FD-ownership hazard resolved in roadmap 8.1 - #231
Closed
leynos wants to merge 1 commit into
Closed
Conversation
Section 8.1 previously presented issues #124 and #125 as a single outstanding pump FD close-race work item. The #125 panic-unwind FD ownership hazard is now fixed in code and regression-tested: with_borrowed_reader wraps the borrowed reader in ManuallyDrop so a caller-owned reader FD stays open on success and panic-unwind, and rust/cuprum-rust/src/lib_tests.rs asserts the borrowed FD survives both normal and panicking operations. Split the section so 8.1.1 scopes the still-outstanding shutdown close-race work to #124, and record #125 as resolved. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Roadmap Section 8.1 previously bundled issues
#124and#125into a single outstanding "pump file-descriptor close race" work item. The#125panic-unwind FD ownership hazard is now fixed in code and regression-tested, so this documentation-only change stops presenting it as outstanding implementation work.Changes
#125as resolved:with_borrowed_readerwraps the borrowed reader inManuallyDrop, keeping a caller-owned reader FD open on both success and panic-unwind;pump_stream/consume_streamroute through the helper; andrust/cuprum-rust/src/lib_tests.rsregression-tests that the borrowed FD survives normal and panicking operations.Bad file descriptorshutdown close race) to the still-outstanding#124.Verification
make markdownlintandmake nixieboth pass (docs-only diff).🤖 Generated with Claude Code
Summary by Sourcery
Documentation: