Skip to content

docs: mark #125 FD-ownership hazard resolved in roadmap 8.1 - #231

Closed
leynos wants to merge 1 commit into
mainfrom
docs/roadmap-125-resolved
Closed

docs: mark #125 FD-ownership hazard resolved in roadmap 8.1#231
leynos wants to merge 1 commit into
mainfrom
docs/roadmap-125-resolved

Conversation

@leynos

@leynos leynos commented Jul 26, 2026

Copy link
Copy Markdown
Owner

Summary

Roadmap Section 8.1 previously bundled issues #124 and #125 into a single outstanding "pump file-descriptor close race" work item. The #125 panic-unwind FD ownership hazard is now fixed in code and regression-tested, so this documentation-only change stops presenting it as outstanding implementation work.

Changes

  • Record #125 as resolved: with_borrowed_reader wraps the borrowed reader in ManuallyDrop, keeping a caller-owned reader FD open on both success and panic-unwind; pump_stream/consume_stream route through the helper; and rust/cuprum-rust/src/lib_tests.rs regression-tests that the borrowed FD survives normal and panicking operations.
  • Rescope task 8.1.1 (the silent Bad file descriptor shutdown close race) to the still-outstanding #124.

Verification

make markdownlint and make nixie both pass (docs-only diff).

🤖 Generated with Claude Code

Summary by Sourcery

Documentation:

Section 8.1 previously presented issues #124 and #125 as a single
outstanding pump FD close-race work item. The #125 panic-unwind FD
ownership hazard is now fixed in code and regression-tested:
with_borrowed_reader wraps the borrowed reader in ManuallyDrop so a
caller-owned reader FD stays open on success and panic-unwind, and
rust/cuprum-rust/src/lib_tests.rs asserts the borrowed FD survives both
normal and panicking operations.

Split the section so 8.1.1 scopes the still-outstanding shutdown
close-race work to #124, and record #125 as resolved.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 878cc08c-b9b1-46ad-8615-8dd62bca87ce

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/roadmap-125-resolved

Comment @coderabbitai help to get the list of available commands.

@leynos leynos closed this Jul 26, 2026
@leynos
leynos deleted the docs/roadmap-125-resolved branch July 26, 2026 14:48
@leynos

leynos commented Jul 26, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #232. The branch was renamed to issue-125-rust-extract-fd-borrow-raii-helper-to-centralise-mem-forget-ownership-contract, which closed this PR; the review continues on #232.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant