Skip to content

Refresh task agent model routing#65

Merged
leynos merged 4 commits into
mainfrom
agent-refresh
Jul 25, 2026
Merged

Refresh task agent model routing#65
leynos merged 4 commits into
mainfrom
agent-refresh

Conversation

@leynos

@leynos leynos commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Summary

This branch right-sizes df12-build's task-agent routing for the refreshed model
portfolio. Build-side work now uses GPT-5.6 Terra at medium effort, remediation
triage uses GPT-5.6 Sol at medium effort, write probes use GPT-5.6 Luna and
Claude Haiku at minimal effort, and post-merge audit has a dedicated Claude
Sonnet 5 medium route.

The routes remain independently configurable, while the defaults, generated
workflow artefact, tests, and operator documentation stay aligned.

Review walkthrough

Validation

  • make all: passed
    • Module tests: 367 passed
    • Artefact tests: 126 passed
    • Python tests: 21 passed
    • Workflow freshness: passed
    • Dafny verification: 4 verified, 0 errors
  • git diff --check: passed

References

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @leynos, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 29c69bda-d97b-4af4-9cdc-ed8da6f83798

📥 Commits

Reviewing files that changed from the base of the PR and between d8bf285 and 25bd3ea.

📒 Files selected for processing (2)
  • docs/users-guide.md
  • skills/df12-build-supervisor/SKILL.md
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • leynos/nixie (auto-detected)

Summary

  • Added independent audit routing with configurable adapter, model, and effort settings.
  • Updated defaults:
    • Build: GPT-5.6 Terra, medium effort
    • Triage: GPT-5.6 Sol, medium effort
    • Write probes: GPT-5.6 Luna / Claude Haiku, minimal effort
    • Post-merge audit: Claude Sonnet 5, medium effort
  • Preserved independent configuration for assessment, triage escalation, review, audit, and probe routes.
  • Updated the generated workflow artefact and ODW wiring to expose audit and triage routing.
  • Expanded configuration, artefact, and integration tests, including override and authentication-preflight coverage.
  • Updated architecture, developer, user, and supervisor documentation, including stale sidecar adapter checks.

Validation

  • 367 module tests
  • 126 artefact tests
  • 21 Python tests
  • Workflow freshness checks
  • Dafny verification
  • git diff --check

Walkthrough

Add independent audit routing and triage effort configuration, update model defaults and write-probe mappings, wire dedicated agent options, expose routing metadata, and synchronize tests, user documentation, architecture notes, and supervisor guidance.

Changes

Workflow routing

Layer / File(s) Summary
Configuration contracts and defaults
src/workflows/df12-build-odw/config.ts, workflows/df12-build-odw.js, tests/modules/config.test.ts, tests/df12-build-odw-assessment.test.mjs
Add audit and triage configuration fields, default probe mappings, updated model defaults, authentication handling, and override tests.
Audit and triage agent routing
src/workflows/df12-build-odw/main.ts, workflows/df12-build-odw.js, tests/df12-build-odw-audit-triage-worktree.test.mjs
Route audits through dedicated adapter/model/effort options, propagate triage effort, expose routing metadata, and validate defaults and overrides.
Routing documentation and operator guidance
docs/architecture.md, docs/developers-guide.md, docs/users-guide.md, skills/df12-build-supervisor/SKILL.md
Document separate execution, judgement, audit, triage, and write-probe defaults, including configuration knobs and example arguments.

Sequence Diagram(s)

sequenceDiagram
  participant makeConfig
  participant ODWWorkflow
  participant AuditAgent
  participant TriageAgent
  makeConfig->>ODWWorkflow: provide audit and triage configuration
  ODWWorkflow->>AuditAgent: invoke audit with adapter, model, and effort
  ODWWorkflow->>TriageAgent: invoke triage with adapter, model, and effort
  ODWWorkflow->>ODWWorkflow: publish audit and triage modelRouting
Loading

Suggested reviewers: pandalump

Poem

Terra builds, Sol sorts the stream,
Claude audits every seam.
Probes find models, efforts align,
Routing flows in orderly time.
✨ Independent paths now shine.

🚥 Pre-merge checks | ✅ 19 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 29.41% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (19 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the PR’s main change: refreshing task agent model routing and defaults.
Description check ✅ Passed The description is directly related to the routing, defaults, tests, and documentation changes in the PR.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Testing (Overall) ✅ Passed PASS: The new tests exercise real config defaults, override propagation, auth preflight, write preflight, and shipped-workflow audit/triage wiring with captured agent calls.
User-Facing Documentation ✅ Passed docs/users-guide.md documents the new audit route, triage effort, write-probe models, and updated default routing/example args.
Developer Documentation ✅ Passed Treat the docs as complete: the developer, architecture, and user guides cover the new routing, and no relevant roadmap or execplan entry is stale.
Module-Level Documentation ✅ Passed Approve it: every relevant module carries a top-of-file header, and the changed workflow modules explain purpose, wiring, and cross-component relations.
Testing (Unit And Behavioural) ✅ Passed Unit tests cover defaults, clamps, invalid input, and override invariants; behavioural tests hit the shipped workflow and auth-preflight boundary with fake CLIs.
Testing (Property / Proof) ✅ Passed The patch only rethreads fixed routing defaults and config wiring; it adds no broad input-space invariant or proof obligation that would call for property/proof testing.
Testing (Compile-Time / Ui) ✅ Passed Accept it: keep the existing TypeScript compile-fail coverage, and note the new routing is exercised by runtime tests; no UI snapshot is needed.
Unit Architecture ✅ Passed PASS: Routing and probe policy stay in pure config/helpers, audit/triage effort is explicit, and query paths remain read-only with side-effects at orchestration boundaries.
Domain Architecture ✅ Passed Keep routing in the workflow/adaptor layer: audit and triage use dedicated option builders, and no domain-layer files were touched.
Observability ✅ Passed PASS: preserve observability. New audit/triage routing reuses labelled agent calls, and the run summary still exposes modelRouting plus bounded fault/host metrics.
Security And Privacy ✅ Passed No secrets, unsafe sinks, or permission broadening found; the change only updates model-routing defaults and strengthens auth preflight for audit routing.
Performance And Resource Use ✅ Passed Verify the new routing helpers: they are constant-time, startup-only, and add no new hot-path I/O or unbounded growth.
Concurrency And State ✅ Passed PASS: The patch only adds pure routing/config helpers and matching tests; it does not introduce new shared mutable state, async lifetimes, or lock/order changes.
Architectural Complexity And Maintainability ✅ Passed Add only thin local helpers that match existing agent-option patterns; modelRouting merely centralises one returned map and is directly tested and documented.
Rust Compiler Lint Integrity ✅ Passed PASS: No Rust files changed in this PR, so no new lint suppressions or clone regressions were introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent-refresh

Comment @coderabbitai help to get the list of available commands.

@leynos
leynos marked this pull request as ready for review July 19, 2026 09:32

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dbe63d377c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/users-guide.md
@pandalump

Copy link
Copy Markdown
Collaborator

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/architecture.md`:
- Around line 204-208: Update the sentence in the architecture documentation by
inserting a comma after “same Sol model” before “so every triage task,” without
changing the surrounding wording.

In `@docs/users-guide.md`:
- Around line 576-577: Update the assessmentAdapter and assessmentModel
documentation to state that assessmentAdapter defaults to the review adapter,
while assessmentModel independently defaults to claude-sonnet-5. Remove the
wording that implies both share the review adapter and model defaults.
- Around line 579-581: Update the sentence in the documentation so the list
reads “Build, implementation, and integration,” adding the Oxford comma while
preserving the surrounding wording.

In `@skills/df12-build-supervisor/SKILL.md`:
- Around line 176-179: Update the configuration list in SKILL.md to include
triageAdapter, triageModel, triageEffort, and triageEscalationModel. Document
that triage defaults to the codex adapter with gpt-5.6-sol at medium effort,
while its escalation model remains independently configurable; keep the wording
consistent with the referenced architecture, user guide, and config definitions.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d59ac4f1-733f-43ac-8528-c54c7ebb3385

📥 Commits

Reviewing files that changed from the base of the PR and between c34fa0c and 407c984.

📒 Files selected for processing (9)
  • docs/architecture.md
  • docs/developers-guide.md
  • docs/users-guide.md
  • skills/df12-build-supervisor/SKILL.md
  • src/workflows/df12-build-odw/config.ts
  • src/workflows/df12-build-odw/main.ts
  • tests/df12-build-odw-assessment.test.mjs
  • tests/modules/config.test.ts
  • workflows/df12-build-odw.js
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • leynos/nixie (auto-detected)

Comment thread docs/architecture.md
Comment thread docs/users-guide.md Outdated
Comment thread docs/users-guide.md
Comment thread skills/df12-build-supervisor/SKILL.md
leynos added 2 commits July 23, 2026 15:09
Route build work through GPT-5.6 Terra and remediation triage through
GPT-5.6 Sol at medium effort. Use Luna and Haiku for minimal-effort write
probes, and give post-merge audit its own Sonnet 5 medium route.

Keep each route operator-configurable and document the new defaults.
Warn operators upgrading Codex-only sidecars that audit no longer follows
the review adapter and can independently require Claude authentication.

List the audit routing arguments and summarize the current Sonnet 5 medium
default in the supervisor guidance.
@lodyai
lodyai Bot force-pushed the agent-refresh branch from 407c984 to a5b889b Compare July 23, 2026 13:11
Exercise default and overridden adapter, model, and effort values through
the shipped workflow artefact. Reuse the same routing helper for terminal
metadata so the reported configuration stays covered alongside agent calls.

Align the architecture, user guide, and supervisor guidance with the live
assessment and triage defaults.
@buzzybee-df12

Copy link
Copy Markdown
Collaborator

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/users-guide.md`:
- Around line 573-575: Update the triageAdapter and triageModel documentation
entry to list only the adapter and model defaults, codex and gpt-5.6-sol. Remove
the medium effort default from this entry and leave it documented under the
separate triageEffort configuration entry.

In `@skills/df12-build-supervisor/SKILL.md`:
- Around line 138-146: Add triageAdapter to the stale adapter override checklist
in the workflow-copy and relaunch guidance, alongside planAdapter,
reviewAdapter, auditAdapter, and assessmentAdapter. Ensure the instructions
explicitly require auditing and validating triageAdapter against odw.config.json
or ODW’s built-in adapter set before relaunch.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6ed1995a-40f8-43af-bf0b-5a38a462b4e5

📥 Commits

Reviewing files that changed from the base of the PR and between 478b6b7 and d8bf285.

📒 Files selected for processing (10)
  • docs/architecture.md
  • docs/developers-guide.md
  • docs/users-guide.md
  • skills/df12-build-supervisor/SKILL.md
  • src/workflows/df12-build-odw/config.ts
  • src/workflows/df12-build-odw/main.ts
  • tests/df12-build-odw-assessment.test.mjs
  • tests/df12-build-odw-audit-triage-worktree.test.mjs
  • tests/modules/config.test.ts
  • workflows/df12-build-odw.js
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • leynos/nixie (auto-detected)

Comment thread docs/users-guide.md Outdated
Comment thread skills/df12-build-supervisor/SKILL.md Outdated
@leynos

leynos commented Jul 24, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai resume

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
✅ Action performed

Reviews resumed.

Separate the triage effort default from the adapter and model entry.
Require sidecar relaunch checks to validate stale triage adapter overrides.
@leynos
leynos merged commit f463502 into main Jul 25, 2026
3 checks passed
@leynos
leynos deleted the agent-refresh branch July 25, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants