📝 CodeRabbit Chat: Implement requested code changes

[coderabbitai]

Code changes was requested by @leynos.

• Stop double-logging external command invocations (#104) #111 (comment)

The following files were modified:

• tests/unit/publish/test_command_logging.py

Summary by Sourcery

Tests:

• Update cmd_mox passthrough logging test to fetch caplog and use_real_invoke via FixtureRequest for compatibility with the test environment.

[coderabbitai]

Important

Review skipped

This PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b03d0475-5892-4e1c-8a77-2ab9fbe5bad3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the test for cmd_mox passthrough logging to obtain fixtures dynamically via pytest’s request object and extends typing helpers to include FixtureRequest for both runtime and typing-only branches.

File-Level Changes

Change	Details	Files
Update pytest type aliases to include FixtureRequest in both runtime and typing-only branches.	Add FixtureRequest alias to the pytest-available branch for proper typing at runtime. Add FixtureRequest alias to the typing-helpers branch for static type checking when pytest is unavailable.	tests/unit/publish/test_command_logging.py
Refactor test_cmd_mox_passthrough_streams_output to fetch fixtures via request instead of direct parameters.	Remove caplog and use_real_invoke from the test function parameters and add request: FixtureRequest instead. Inside the test, retrieve caplog via request.getfixturevalue("caplog") and call request.getfixturevalue("use_real_invoke") to ensure those fixtures are still used. Keep the existing logging level setup, environment monkeypatching, and cmd_mox invocation behavior intact.	tests/unit/publish/test_command_logging.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've found 1 issue, and left some high level feedback:

• Consider keeping caplog and use_real_invoke as explicit test parameters instead of fetching them via request.getfixturevalue, unless you truly need the dynamic lookup, as explicit fixture injection is clearer and better communicates test dependencies.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider keeping `caplog` and `use_real_invoke` as explicit test parameters instead of fetching them via `request.getfixturevalue`, unless you truly need the dynamic lookup, as explicit fixture injection is clearer and better communicates test dependencies.

## Individual Comments

### Comment 1
<location path="tests/unit/publish/test_command_logging.py" line_range="94" />
<code_context>
     caplog.set_level(logging.INFO, logger="lading.testing.cmd_mox_runner")
     monkeypatch.setenv("LADING_USE_CMD_MOX_STUB", "1")
     script = "print('unused')"
-    cmd_mox.spy(sys.executable).with_args("-c", script).passthrough()
+

</code_context>
<issue_to_address>
**issue (testing):** The test no longer invokes `cmd_mox`, so it may not validate passthrough behavior anymore.

With the removal of `cmd_mox.spy(sys.executable).with_args("-c", script).passthrough()` and no replacement, `test_cmd_mox_passthrough_streams_output` no longer appears to trigger the passthrough/streaming behavior it’s supposed to verify. This risks making the test effectively a no-op. Please reintroduce an explicit `cmd_mox` invocation (adapted if needed) or add a new call that actually exercises passthrough so the test still confirms that subprocess output is streamed and logged.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (testing): The test no longer invokes cmd_mox, so it may not validate passthrough behavior anymore.

With the removal of cmd_mox.spy(sys.executable).with_args("-c", script).passthrough() and no replacement, test_cmd_mox_passthrough_streams_output no longer appears to trigger the passthrough/streaming behavior it’s supposed to verify. This risks making the test effectively a no-op. Please reintroduce an explicit cmd_mox invocation (adapted if needed) or add a new call that actually exercises passthrough so the test still confirms that subprocess output is streamed and logged.