Add Hypothesis tests for bump_lockfiles path resolution (#93)

[leynos]

Summary

Closes #93

Property tests covering the four invariants of manifest-path resolution in bump_lockfiles:

• Path normalisation — arbitrary in-workspace manifest strings (including redundant . segments) always produce a normalised sibling Cargo.lock path inside the workspace.
• Deduplication — every spelling of the workspace root manifest (Cargo.toml, ./Cargo.toml, repeated) produces exactly one root entry.
• Ordering invariant — the workspace root Cargo.lock is always the first element, regardless of input order; resolved paths are unique.
• Rejection invariant — any manifest path escaping the workspace root raises LockfileRegenerationError. The escape test anchors the workspace in a subdirectory and excludes (via assume) the degenerate suffix that would legitimately resolve back inside.

Testing

• make check-fmt, make lint, make typecheck, and make test (697 passed) all green after rebasing onto current main.

🤖 Generated with Claude Code

Summary by Sourcery

Add property-based tests to verify manifest path resolution behavior in bump_lockfiles, including normalization, deduplication, ordering, and rejection of paths escaping the workspace root.

Tests:

• Introduce Hypothesis-based property tests ensuring in-workspace manifests resolve to normalized sibling Cargo.lock files with unique paths and correct ordering.
• Add tests confirming multiple spellings of the workspace root manifest deduplicate to a single root Cargo.lock entry.
• Add tests asserting that manifest paths attempting to escape the workspace root are rejected with LockfileRegenerationError.

References

• Lody session: https://lody.ai/leynos/sessions/47cdf895-d6fd-46e2-aaec-00258f986cc4

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 0c79d618-f2f5-41e4-a752-e8e0adc69f10

📥 Commits

Reviewing files that changed from the base of the PR and between fb13d90 and fa8c1b2.

📒 Files selected for processing (1)

• tests/unit/test_bump_lockfiles.py

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• leynos/cmd-mox (auto-detected)
• leynos/cuprum (auto-detected)
• leynos/shared-actions (auto-detected)

---

Summary

Adds Hypothesis property-based tests for bump_lockfiles manifest-path resolution, addressing #93.

Test coverage

• Normalises arbitrary in-workspace manifest paths, including redundant . and safe .. segments.
• Resolves manifests to unique sibling Cargo.lock files while preserving order.
• Ensures the workspace Cargo.lock is returned first.
• Deduplicates root manifest spellings such as Cargo.toml and ./Cargo.toml.
• Rejects paths escaping the workspace root with LockfileRegenerationError.

Formatting, linting, type checking, and the full test suite pass with 697 tests.

Walkthrough

Add Hypothesis property tests for resolve_lockfile_paths, covering sibling lockfile resolution, root-path deduplication, ordering, normalisation, and rejection of manifests that escape the workspace.

Changes

Lockfile path validation

Layer / File(s)	Summary
Property-based manifest path checks tests/unit/test_bump_lockfiles.py	Add generated tests for in-workspace path normalisation, sibling Cargo.lock resolution, root lockfile ordering and deduplication, and rejection of escaping paths with LockfileRegenerationError.

Possibly related PRs

• leynos/lading#135: Wraps resolve_lockfile_paths behind CargoLockfileRepository, complementing these path-resolution tests.

Suggested labels: Issue

Poem

Paths twist and turn,
Root locks gather at the front,
Duplicates fade out.
.. meets a firm boundary,
Hypothesis guards the route.

🚥 Pre-merge checks | ✅ 20

✅ Passed checks (20 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title matches the PR scope and includes the linked issue reference (#93).
Description check	✅ Passed	The description is on topic and describes the property tests added for bump_lockfiles.
Linked Issues check	✅ Passed	The changes cover the required Hypothesis tests for normalisation, deduplication, ordering, and workspace escape rejection in #93.
Out of Scope Changes check	✅ Passed	Keep the changes within the test coverage scope; no unrelated code changes are indicated.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Testing (Overall)	✅ Passed	The Hypothesis tests use real paths and fail on plausible regressions in normalisation, deduplication, ordering, and escape rejection.
User-Facing Documentation	✅ Passed	PASS: PR only adds tests; no new user-facing behaviour was introduced, and the users guide already documents lockfile regeneration and its options.
Developer Documentation	✅ Passed	PASS: The PR only adds Hypothesis tests; no internal API, architecture, tooling, roadmap, or execplan changes were introduced, so no doc update was required.
Module-Level Documentation	✅ Passed	PASS: tests/unit/test_bump_lockfiles.py starts with a module docstring describing its lockfile-regeneration test purpose.
Testing (Unit And Behavioural)	✅ Passed	Pass: keep the Hypothesis tests on the public resolver API; cover normalisation, dedupe, ordering, and escape rejection without private seams.
Testing (Property / Proof)	✅ Passed	PASS: The PR adds Hypothesis properties for manifest-path normalisation, deduplication, ordering, and escape rejection in test_bump_lockfiles.py.
Testing (Compile-Time / Ui)	✅ Passed	PASS: the PR only changes Python property tests; it adds no Rust/TS compile-time path or UI/text snapshot surface, so the trybuild/snapshot rule is not applicable.
Unit Architecture	✅ Passed	The patch only adds property tests for a pure resolver and an injected command path; it does not blur query/command boundaries or hide side-effects.
Domain Architecture	✅ Passed	Only tests changed, and they exercise the command-layer port/repository API; no domain model now depends on transport or filesystem details.
Observability	✅ Passed	Pass this: the patch is test-only, so it adds no production logging, metrics, tracing, or alerts to evaluate.
Security And Privacy	✅ Passed	Only unit tests changed; they use synthetic paths and no secrets, credentials, logs, or broadened permissions.
Performance And Resource Use	✅ Passed	Only bounded Hypothesis tests were added; no production code changed, and all new generators cap size/examples and use temp dirs.
Concurrency And State	✅ Passed	PASS: The PR only adds synchronous property tests around pure path-resolution code; no shared mutable state, async work, locks, or lifetimes were introduced.
Architectural Complexity And Maintainability	✅ Passed	PASS: Only tests/unit/test_bump_lockfiles.py changed; the production resolver is unchanged, and the new helpers stay local to the test module.
Rust Compiler Lint Integrity	✅ Passed	Only tests/unit/test_bump_lockfiles.py changed; no Rust files, lint suppressions, or clone-heavy ownership changes were introduced.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch issue-93-hypothesis-bump-lockfiles-paths

---

_{Comment @coderabbitai help to get the list of available commands.}

[sourcery-ai]

Reviewer's Guide

Adds Hypothesis-based property tests to validate bump_lockfiles manifest path resolution invariants, including normalization, deduplication, ordering, and rejection of paths escaping the workspace root.

File-Level Changes

Change	Details	Files
Introduce Hypothesis property-based tests that exercise manifest path resolution invariants in bump_lockfiles.resolve_lockfile_paths.	Add Hypothesis and supporting imports (strategies, given, settings, assume, string, tempfile, Path) and remove unused TYPE_CHECKING gate for Path. Define reusable Hypothesis strategies for safe path segments and in-workspace directory lists, plus a helper to render manifest path strings from components. Add a property test ensuring arbitrary in-workspace manifests resolve to sibling Cargo.lock files under the workspace root, with normalized paths, root-first ordering, and uniqueness of resolved lockfile paths. Add a property test that multiple spellings of the workspace root manifest (e.g., Cargo.toml and ./Cargo.toml) deduplicate to a single root Cargo.lock entry. Add a property test that manifests whose paths escape the workspace root (using .. segments) are rejected with LockfileRegenerationError, anchoring the workspace in a subdirectory and using assume to exclude degenerate suffixes.	tests/unit/test_bump_lockfiles.py

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#93	Add Hypothesis property-based tests to verify path normalisation: arbitrary relative manifest strings that resolve inside the workspace always produce a sibling Cargo.lock path.	✅
#93	Add Hypothesis property-based tests to verify deduplication and ordering invariants: any combination of manifest paths that normalise to the workspace root manifest produces exactly one root invocation, and the workspace root Cargo.lock is always the first element returned with unique resolved paths.	✅
#93	Add Hypothesis property-based tests to verify the rejection invariant: any manifest path that escapes the workspace root raises LockfileRegenerationError.	✅

Possibly linked issues

• Add Hypothesis property-based tests for path normalisation and deduplication in bump_lockfiles #93: The PR adds the exact Hypothesis property-based tests for bump_lockfiles path invariants requested in issue Add Hypothesis property-based tests for path normalisation and deduplication in bump_lockfiles #93.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[leynos]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[pandalump]

@coderabbitai resume

[coderabbitai]

✅ Action performed

Reviews resumed.

[leynos]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[leynos]

@coderabbitai resume

[coderabbitai]

✅ Action performed

Reviews resumed.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/unit/test_bump_lockfiles.py`:
- Around line 289-295: Extend the _INSIDE_DIR Hypothesis strategy to generate
safe ".." parent-traversal segments alongside _SEGMENT and "." entries, while
keeping generated paths within the workspace after normalization. Preserve the
existing bounds and ensure cases such as crate/../Cargo.toml are exercised
without allowing traversal above the workspace root.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2019179c-15d3-44a0-978b-3a6e01cbde43

📥 Commits

Reviewing files that changed from the base of the PR and between 2dc6390 and fb13d90.

📒 Files selected for processing (1)

• tests/unit/test_bump_lockfiles.py

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• leynos/cmd-mox (auto-detected)
• leynos/cuprum (auto-detected)
• leynos/shared-actions (auto-detected)

[codescene-access]

No quality gates enabled for this code.

[buzzybee-df12]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.