Move cmd-mox behind a CommandRunner port (#62)

[lodyai]

Summary

This branch moves the cmd-mox IPC integration for issue #62 out of production modules and behind a CommandRunner port selected at the CLI boundary.

Closes #62.

Production code now depends on the runtime command-runner protocol and default subprocess adapter, while the cmd-mox adapter lives under lading.testing and is loaded only when LADING_USE_CMD_MOX_STUB is enabled.

Review walkthrough

• Start with lading/runtime/runner.py and lading/runtime/subprocess_runner.py for the production port and subprocess adapter.
• Then review lading/testing/cmd_mox_runner.py for the test-only cmd-mox IPC and passthrough adapter.
• Review lading/cli.py and lading/workspace/metadata.py for runner selection and cargo metadata routing.
• Finish with tests/unit/test_cmd_mox_integration.py, tests/unit/test_cargo_metadata_loading.py, and tests/bdd/steps/test_publish_infrastructure.py for the updated test coverage.

Validation

• make check-fmt: passed.
• make lint: passed with Ruff clean and Pylint at 10.00/10.
• make typecheck: passed with ty check clean.
• make test: passed, 465 tests and 14 snapshots.
• grep -R "cmd_mox" -n lading: passed with hits only under lading/testing/cmd_mox_runner.py.
• coderabbit review --agent: passed with zero findings after follow-up fixes.

[coderabbitai]

Warning

Review limit reached

@leynos, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 55 minutes and 50 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 23c13dc7-62ed-4f0c-b631-89c33d18f189

📥 Commits

Reviewing files that changed from the base of the PR and between 48d027c and 6785cdd.

📒 Files selected for processing (24)

• lading/cli.py
• lading/commands/publish.py
• lading/commands/publish_execution.py
• lading/commands/publish_preflight.py
• lading/runtime/__init__.py
• lading/runtime/runner.py
• lading/runtime/subprocess_runner.py
• lading/testing/cmd_mox_runner.py
• lading/workspace/metadata.py
• tests/bdd/steps/test_publish_given_steps.py
• tests/bdd/steps/test_publish_infrastructure.py
• tests/bdd/steps/test_publish_when_steps.py
• tests/helpers/workspace_helpers.py
• tests/unit/publish/test_command_helpers.py
• tests/unit/publish/test_command_logging.py
• tests/unit/publish/test_formatting_helpers.py
• tests/unit/publish/test_preflight_arguments.py
• tests/unit/publish/test_preflight_checks.py
• tests/unit/publish/test_publish_execution_helpers.py
• tests/unit/publish/test_run_integration.py
• tests/unit/test_cargo_metadata_loading.py
• tests/unit/test_cmd_mox_integration.py
• tests/unit/test_metadata_helpers.py
• tests/unit/test_publish_formatting.py

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch issue-62-move-cmd-mox-integration-behind-a-commandrunner-port

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sourcery-ai]

Sorry @LodyAI[bot], you have reached your weekly rate limit of 2500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[leynos]

@coderabbitai Please suggest a fix for this issue and supply a prompt for an AI coding agent to enable it to apply the fix. Include the file and symbol names indicated in the issue at the head of your response.

lading/workspace/metadata.py

Comment on lines +114 to +115

    *,
    runner: CommandRunner | None = None,

❌ New issue: Complex Method
load_cargo_metadata has a cyclomatic complexity of 11, threshold = 9

[sourcery-ai]

Sorry @leynos, you have reached your weekly rate limit of 2500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[leynos]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[leynos]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[leynos]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[leynos]

@coderabbitai Please suggest a fix for this issue and supply a prompt for an AI coding agent to enable it to apply the fix. Include the file and symbol names indicated in the issue at the head of your response.

lading/runtime/subprocess_runner.py

Comment on lines +125 to +204

def invoke_via_subprocess(
    program: str,
    args: tuple[str, ...],
    context: SubprocessContext,
) -> tuple[int, str, str]:
    """Spawn ``program`` with ``args`` while proxying its output streams.

    Parameters
    ----------
    program:
        Program to execute.
    args:
        Arguments to pass to ``program``.
    context:
        Working directory, environment, and optional stdin payload.

    Returns
    -------
    tuple[int, str, str]
        Exit code, captured stdout, and captured stderr.

    Raises
    ------
    CommandSpawnError
        If the subprocess cannot be created.

    """
    command = (program, *args)
    _log_subprocess_spawn(command, context.cwd)
    _log_subprocess_environment(context.env)
    normalised_env = normalise_environment(context.env)
    try:
        # This path owns `Popen` directly so relay threads can drain both pipes
        # before the function returns. S603 is mitigated because `command` is a
        # pre-split sequence and the default `shell=False` is used.
        process = subprocess.Popen(  # noqa: S603 # pylint: disable=consider-using-with
            command,
            cwd=None if context.cwd is None else str(context.cwd),
            env=normalised_env,
            stdout=subprocess.PIPE,
            stderr=subprocess.PIPE,
            stdin=subprocess.PIPE if context.stdin_data is not None else None,
        )
    except OSError as exc:
        raise CommandSpawnError(program, exc) from exc

    stdout_chunks: list[str] = []
    stderr_chunks: list[str] = []
    threads = [
        threading.Thread(
            target=relay_stream,
            args=(
                process.stdout,
                sys.stdout if context.echo_stdout else None,
                stdout_chunks,
            ),
            name=_format_thread_name(program, "stdout"),
            daemon=True,
        ),
        threading.Thread(
            target=relay_stream,
            args=(process.stderr, sys.stderr, stderr_chunks),
            name=_format_thread_name(program, "stderr"),
            daemon=True,
        ),
    ]
    for thread in threads:
        thread.start()
    try:
        if context.stdin_data is not None and process.stdin is not None:
            try:
                process.stdin.write(context.stdin_data.encode("utf-8"))
                process.stdin.close()
            except BrokenPipeError:
                _LOGGER.debug("Process closed stdin before all data was written")
    finally:
        exit_code = process.wait()
        for thread in threads:
            thread.join()
    return exit_code, "".join(stdout_chunks), "".join(stderr_chunks)

❌ New issue: Large Method
invoke_via_subprocess has 72 lines, threshold = 70

[leynos]

@coderabbitai Please suggest a fix for this issue and supply a prompt for an AI coding agent to enable it to apply the fix. Include the file and symbol names indicated in the issue at the head of your response.

lading/runtime/subprocess_runner.py

Comment on lines +125 to +204

def invoke_via_subprocess(
    program: str,
    args: tuple[str, ...],
    context: SubprocessContext,
) -> tuple[int, str, str]:
    """Spawn ``program`` with ``args`` while proxying its output streams.

    Parameters
    ----------
    program:
        Program to execute.
    args:
        Arguments to pass to ``program``.
    context:
        Working directory, environment, and optional stdin payload.

    Returns
    -------
    tuple[int, str, str]
        Exit code, captured stdout, and captured stderr.

    Raises
    ------
    CommandSpawnError
        If the subprocess cannot be created.

    """
    command = (program, *args)
    _log_subprocess_spawn(command, context.cwd)
    _log_subprocess_environment(context.env)
    normalised_env = normalise_environment(context.env)
    try:
        # This path owns `Popen` directly so relay threads can drain both pipes
        # before the function returns. S603 is mitigated because `command` is a
        # pre-split sequence and the default `shell=False` is used.
        process = subprocess.Popen(  # noqa: S603 # pylint: disable=consider-using-with
            command,
            cwd=None if context.cwd is None else str(context.cwd),
            env=normalised_env,
            stdout=subprocess.PIPE,
            stderr=subprocess.PIPE,
            stdin=subprocess.PIPE if context.stdin_data is not None else None,
        )
    except OSError as exc:
        raise CommandSpawnError(program, exc) from exc

    stdout_chunks: list[str] = []
    stderr_chunks: list[str] = []
    threads = [
        threading.Thread(
            target=relay_stream,
            args=(
                process.stdout,
                sys.stdout if context.echo_stdout else None,
                stdout_chunks,
            ),
            name=_format_thread_name(program, "stdout"),
            daemon=True,
        ),
        threading.Thread(
            target=relay_stream,
            args=(process.stderr, sys.stderr, stderr_chunks),
            name=_format_thread_name(program, "stderr"),
            daemon=True,
        ),
    ]
    for thread in threads:
        thread.start()
    try:
        if context.stdin_data is not None and process.stdin is not None:
            try:
                process.stdin.write(context.stdin_data.encode("utf-8"))
                process.stdin.close()
            except BrokenPipeError:
                _LOGGER.debug("Process closed stdin before all data was written")
    finally:
        exit_code = process.wait()
        for thread in threads:
            thread.join()
    return exit_code, "".join(stdout_chunks), "".join(stderr_chunks)

❌ New issue: Large Method
invoke_via_subprocess has 72 lines, threshold = 70

[codescene-delta-analysis]

Our agent can fix these. Install it.

Gates Passed
6 Quality Gates Passed

Absence of Expected Change Pattern

• lading/lading/cli.py is usually changed with: lading/tests/unit/test_cli.py
• lading/lading/commands/publish.py is usually changed with: lading/tests/bdd/steps/test_publish_steps.py

Quality Gate Profile: Pay Down Tech Debt
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

[leynos]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.