Update ordered-float requirement from 3 to 5 - #267
Conversation
There was a problem hiding this comment.
Sorry @dependabot[bot], you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
@dependabot rebase |
1c87388 to
9f1a6c0
Compare
|
@dependabot recreate |
9f1a6c0 to
f6f36c0
Compare
|
@coderabbitai Please investigate the cause of the following issue using codegraph exploration and research, identify a fix and provide an AI coding agent prompt for the fix: |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '%s\n' '== manifests and lockfile references =='
fd -t f '^(Cargo\.toml|Cargo\.lock)$' . -x sh -c '
printf "\n-- %s --\n" "$1"
rg -n -C2 "ordered-float|feldera-size-of|size-of|dbsp" "$1" || true
' sh {} \;
printf '%s\n' '== relevant source outlines =='
for f in src/components.rs src/macros.rs src/dbsp_circuit/types.rs src/dbsp_circuit/streams/behaviour.rs src/dbsp_circuit/streams/kinematics/mod.rs; do
if [ -f "$f" ]; then
printf "\n-- %s --\n" "$f"
ast-grep outline "$f" --items all || true
fi
done
printf '%s\n' '== SizeOf and OrderedFloat uses/implementations =='
rg -n -C3 --glob '*.rs' \
'(SizeOf|OrderedFloat|ordered_float|__macro_deps|size_of::)' src || true
printf '%s\n' '== locally cached dependency sources, if available =='
registry_root="${CARGO_HOME:-$HOME/.cargo}/registry/src"
if [ -d "$registry_root" ]; then
fd -t d -d 2 '^(ordered-float|feldera-size-of|size-of)-' "$registry_root" | while IFS= read -r d; do
printf "\n-- %s --\n" "$d"
rg -n -C2 'trait SizeOf|impl.*SizeOf|OrderedFloat|feature' "$d" -g '*.rs' -g 'Cargo.toml' || true
done
fiLength of output: 51914 🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '%s\n' '== resolved dependency package stanzas =='
if [ -f Cargo.lock ]; then
awk '
/^\[\[package\]\]/ { block=$0 "\n"; next }
/^\[\[/ { block=""; next }
{ block=block $0 "\n" }
/name = "(ordered-float|feldera-size-of|dbsp)"/ { print block; print "---" }
' Cargo.lock
fi
printf '%s\n' '== root library dependency facade and record macro =='
sed -n '1,55p' src/lib.rs
sed -n '85,145p' src/macros.rs
sed -n '90,190p' src/dbsp_circuit/types.rs
sed -n '90,155p' src/components.rs
printf '%s\n' '== dependency graph evidence in Cargo metadata (without building) =='
cargo metadata --no-deps --format-version 1 2>/dev/null | \
jq -r '.packages[] | select(.name == "lille") | .dependencies[] |
select(.name == "ordered-float" or .name == "feldera-size-of" or .name == "dbsp") |
"\(.name) package=\(.package // .name) req=\(.req) features=\(.features|join(","))"' || true
printf '%s\n' '== public crates.io package metadata =='
for crate in feldera-size-of ordered-float; do
echo "-- $crate --"
curl --fail --silent --show-error "https://crates.io/api/v1/crates/${crate}" |
jq -r '.crate | "newest=\(.newest_version) max_stable=\(.max_stable_version) repository=\(.repository // "")"'
done
printf '%s\n' '== download and inspect feldera-size-of release source =='
version="$(grep -A6 -E '^name = "feldera-size-of"$' Cargo.lock 2>/dev/null | awk -F'"' '/^version = / { print $2; exit }')"
if [ -n "${version:-}" ]; then
tmp="$(mktemp -d)"
trap 'rm -rf "$tmp"' EXIT
curl --fail --silent --show-error -L \
"https://crates.io/api/v1/crates/feldera-size-of/${version}/download" \
-o "$tmp/crate.tar.gz"
tar -xzf "$tmp/crate.tar.gz" -C "$tmp"
fd -t f . "$tmp" -x sh -c '
case "$1" in
*/Cargo.toml|*.rs)
rg -n -C3 "ordered-float|ordered_float|OrderedFloat|trait SizeOf|impl.*SizeOf" "$1" || true ;;
esac
' sh {} \;
else
echo "feldera-size-of was not found in Cargo.lock"
fiLength of output: 10938 🤖 web_search executed:
Length of output: 4909 🤖 web_search executed:
Length of output: 7452 🤖 web_search executed:
Length of output: 790
Root causeKeep
Do not add Do not implement FixPatch or update size-of = {
version = "0.1",
package = "feldera-size-of",
features = ["ordered-float"],
}The patch must change the integration crate’s optional dependency constraint from Use one of these routes:
Affected code graph
AI coding-agent prompt |
Updates the requirements on [ordered-float](https://github.com/reem/rust-ordered-float) to permit the latest version. - [Release notes](https://github.com/reem/rust-ordered-float/releases) - [Commits](reem/rust-ordered-float@v3.0.0...v5.0.0) --- updated-dependencies: - dependency-name: ordered-float dependency-version: 5.0.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
f6f36c0 to
11329c4
Compare
Rebasing might not happen immediately, so don't worry if this takes some time.
Note: if you make any changes to this PR yourself, they will take precedence over the rebase.
Updates the requirements on ordered-float to permit the latest version.
Release notes
Sourced from ordered-float's releases.
Commits
478e67dVersion 5.0.05c8edf3Implement Hash for f32 and f64 only.428ab8cMerge pull request #167 from Ten0/less_implicit_panic_on_binary_operations86f0b79Adapt tests8ff0bb1Re-add NotNan x PossiblyNan operations (now returning PossiblyNan)f9fd9a7Remove evil implsfacb424Increase rust-version to 1.631740c93Add libm-only tests to CI1b0686eVersion 4.6.05dc9e28Update Cargo.lock