Sync typos dictionary cache from shared authority - #296
Draft
lodyai[bot] wants to merge 1 commit into
Draft
Conversation
Regenerated `typos.toml` picks up the newer estate dictionary entries (polymerise/polymerize family) emitted by the spelling gate. This is a generated cache refresh with no policy change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lodyai Bot
pushed a commit
that referenced
this pull request
Jul 23, 2026
Regenerated `typos.toml` picks up the shared authority's polymer-stem corrections (polymeris*/polymeriz*). `make spelling` reproduces these on every run because the estate dictionary is ahead of main, so the branch cannot keep them out until the refresh lands on main. The same change is proposed standalone in PR #296; once that merges to main and this branch rebases, git absorbs this duplicate as a no-op. Generated-file cache refresh only; no policy change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
lodyai Bot
pushed a commit
that referenced
this pull request
Jul 23, 2026
Regenerated `typos.toml` picks up the shared authority's polymer-stem corrections (polymeris*/polymeriz*). `make spelling` reproduces these on every run because the estate dictionary is ahead of main, so the branch cannot keep them out until the refresh lands on main. The same change is proposed standalone in PR #296; once that merges to main and this branch rebases, git absorbs this duplicate as a no-op. Generated-file cache refresh only; no policy change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
leynos
pushed a commit
that referenced
this pull request
Jul 24, 2026
* Adopt Bevy 0.18.1 and bevy_ecs_tiled 0.12 Move the workspace to the latest Bevy release compatible with the pinned nightly toolchain (rustc 1.91). Bevy 0.19 requires Rust 1.95, so it cannot build here; 0.18.1 is the highest usable line. - Set workspace `bevy` and every direct Bevy subcrate (`bevy_app`, `bevy_ecs`, `bevy_math`, `bevy_reflect`, `bevy_transform`, `bevy_log`) to the 0.18.1 release line, preserving required features including `bevy_reflect`'s `auto_register_inventory`. - Upgrade `bevy_ecs_tiled` from 0.10 to 0.12, the Bevy-0.18 line, keeping the `png` and `user_properties` features. - Migrate the buffered-event API renamed in Bevy 0.18: `EventReader` -> `MessageReader` for `TiledEvent<MapCreated>` readers, and `World::send_event` -> `World::write_message` in the map test helpers. - Drop the now-unfulfilled `#[expect(deprecated)]` attributes that guarded the legacy bevy_ecs_tiled 0.10 event API. Observer events (`On<T>` / `trigger` / `add_observer`) already match the 0.18 `Event` semantics and are unchanged. `rust-toolchain.toml` stays on the pinned nightly for this update. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Drop redundant #[must_use] on App-returning test builders Bevy 0.18 marks `App` as `#[must_use]`, so the local `#[must_use]` attributes on `DbspTestAppBuilder::build` and `build_with_entity` now trigger `clippy::double_must_use`. Remove them; the return types remain must-use through `App` itself. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Document the Bevy 0.18.1 and bevy_ecs_tiled 0.12 stack Contributors are directed to the docs as the source of truth, but the Bevy migration plan still recorded 0.17.3 and bevy_ecs_tiled 0.9/0.10 as the active target, giving obsolete dependency guidance now that the workspace runs Bevy 0.18.1 and bevy_ecs_tiled 0.12. - Add `docs/developers-guide.md` as the source of truth for the active Bevy and bevy_ecs_tiled versions, feature flags, the Message vs observer event split, and the nightly toolchain constraint that keeps Bevy 0.19 out of scope. - Mark the Bevy 0.16+ migration plan as archived and historical, and append a "Bevy 0.17.3 -> 0.18.1" record covering the version bumps, the Message API migration (EventReader -> MessageReader, send_event -> write_message), and the toolchain constraint. - Update the physics/world-engine roadmap checklist: Phase 5 (0.17.3) done and a new Phase 6 (0.18.1 + bevy_ecs_tiled 0.12) done. - Index the developer's guide and the archived plan in docs/README.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Add compile-pass guard for the Bevy 0.18 message migration The runtime map tests exercise the migrated buffered-message APIs dynamically, but nothing pins the API surface at compile time, so a regression to the legacy `EventReader` / `World::send_event` names could reappear if the runtime tests were ever weakened. Add an isolated compile-pass check alongside the existing runtime coverage. - Add `trybuild` as a dev-dependency and a `tests/compile_pass.rs` harness (gated on `test-support`, like the other map tests) that runs a single `t.pass(...)` fixture. - Add the fixture `tests/compile_pass/message_reader_migration.rs`, which compiles only when the supported APIs are used: `MessageReader<TiledEvent<MapCreated>>` (not `EventReader`) and `World::write_message(TiledEvent::new(...))` (not `send_event`). It activates the same `map`/`test-support` feature path as the production map integration via the `lille` dev-dependency. - Carry `bevy_ecs_tiled` 0.12 as a non-optional dev-dependency so the standalone fixture crate (built by trybuild as its own package) can name it; in-package tests still reach it through the optional `map`/`test-support` path, and the lille dev-dependency already pulls `test-support`, so this adds no new compilation. - Document the harness and its command in the developer's guide. Only a compile-pass fixture is added (no snapshot-based fail fixture), so there is no fragile stderr snapshot to maintain. Runs under `make test` and `cargo test --features test-support --test compile_pass`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Address review feedback on the compile-pass harness and docs Fixes still-valid code-review findings on PR #283. - Correct the Bevy 0.19 compatibility notes: bevy_ecs_tiled 0.13 does support Bevy 0.19, so the plugin is no longer the blocker; the sole remaining blocker is the Rust 1.95.0 toolchain requirement. Updated docs/developers-guide.md, docs/bevy-0-16-plus-migration-plan.md, and docs/lille-physics-and-world-engine-roadmap.md. - Sync the roadmap Bevy Upgrade Checklist with reality: mark Phases 2-4 done with their recorded completion dates (21/23/25 November 2025), matching the migration plan's per-phase status sections. Phases 5 and 6 details are preserved. - tests/compile_pass.rs: move the `//!` module documentation above the `cfg_attr`/`cfg` crate attributes so the file opens with its purpose doc, and clarify that the trybuild fixture names bevy_ecs_tiled via a direct non-optional dev-dependency (distinct from lille's test-support feature path). Aligned the fixture's own doc comment to match. - Cargo.toml: declare an explicit `[[test]]` for compile_pass with `required-features = ["test-support"]`, making the feature requirement explicit and deterministic so Cargo skips the target when the feature is unavailable rather than building an empty one. Skipped the typos.toml finding: the polymerise/polymerize mappings are not hand edits but are algorithmically derived from the shared "polymer" Oxford stem in the estate-wide authority dictionary. typos.toml is a fully regenerated do-not-hand-edit artefact, so moving those lines into typos.local.toml and regenerating would re-add them identically (a no-op) or break `make spelling`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Sync typos dictionary cache from shared authority Regenerated `typos.toml` picks up the shared authority's polymer-stem corrections (polymeris*/polymeriz*). `make spelling` reproduces these on every run because the estate dictionary is ahead of main, so the branch cannot keep them out until the refresh lands on main. The same change is proposed standalone in PR #296; once that merges to main and this branch rebases, git absorbs this duplicate as a no-op. Generated-file cache refresh only; no policy change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Caption the dependency table and refresh stale event-API doc snippets Addresses review feedback on PR #283. - docs/developers-guide.md: add a short caption above the Bevy dependency table identifying it as the active dependency versions table (table content unchanged). - Update stale Bevy 0.17 buffered-event snippets to the Bevy 0.18 Message API (`EventReader<TiledEvent<MapCreated>>` -> `MessageReader<...>`) in the map design doc and two execplans: - docs/lille-isometric-tiled-maps-design.md (plus the adjacent "message-reader systems" prose) - docs/execplans/pres-task-1-2-4-support-slope-metadata-for-terrain.md - docs/execplans/pres-task-1-2-1-translate-map-data-into-engine-state.md Skipped, with reasons: - The bevy_ecs_tiled dev-dependency feature finding: verified via the resolved feature graph that its own `png`/`user_properties` pull in no render/window/GPU; those features come from lille's pre-existing `test-support`/`render` design (which the map tests require), not from the dev-dependency. png+user_properties are already minimal; altering them would not change GPU enablement and could break the trybuild fixture. - The line-31 "Surprises & Discoveries" note in the 1-2-1 execplan is a dated historical record (accurate for the bevy_ecs_tiled 0.10 era) and is left verbatim rather than rewritten. - docs/bevy-headless-testing.md uses generic `MyEvent` examples unrelated to the TiledEvent map path; out of scope for this fix. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: leynos <leynos@rohga> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refreshes the generated
typos.tomlspelling dictionary from the shareden-GB-oxendict authority, picking up the
polymeris*/polymeriz*correctionfamily derived from the
polymerOxford stem.This is a mechanical, generated-file sync with no policy change: the entries
are produced by
scripts/generate_typos_config.pyexpanding the shared authoritydictionary's
polymerstem, not by hand. It was split out of the Bevy 0.18.1migration branch (PR #283) so that unrelated dependency/migration review does not
carry an incidental dictionary regeneration.
Details
typos.tomlchanges (+18 lines): thepolymeris*→polymeriz*mappings.make spelling(runsscripts/generate_typos_config.py,which merges the shared authority base with
typos.local.toml).Validation
make spelling— the generated output matches these entries (deterministicregeneration from the shared authority stem list).