Add IR property tests (#322)#325
Draft
lodyai[bot] wants to merge 1 commit into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Add `proptest` coverage for cycle detection, Ninja dependency separator ordering, and command interpolation placeholder handling. Centralize manifest placeholder tokens so rendering and interpolation share the same constants, and add shared path generation helpers for property strategies.
1248aea to
147f587
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch adds property-based coverage for the invariants introduced around
PR #315: IR cycle detection now has generated DAG, cycle, missing-dependency,
order-only exclusion, and insertion-order determinism checks; Ninja build-line
formatting now checks dependency separator ordering; and command interpolation
now checks placeholder substitution around backtick-delimited regions.
Closes #322.
It also centralizes the manifest placeholder tokens used by rendering and
interpolation so the tests and implementation share one source of truth.
Review walkthrough
Validation
cargo test --all-targets --all-features property_tests: passed, 11 property tests.make check-fmt: passed.make lint: passed.make test: passed.coderabbit review --agent: run after each review milestone; all substantive concerns were addressed before this PR was opened.