Skip to content

Add IR property tests (#322)#325

Draft
lodyai[bot] wants to merge 1 commit into
mainfrom
issue-322-property-tests-for-cycle-detection-ninja-separator-ordering-and-command-interpolation
Draft

Add IR property tests (#322)#325
lodyai[bot] wants to merge 1 commit into
mainfrom
issue-322-property-tests-for-cycle-detection-ninja-separator-ordering-and-command-interpolation

Conversation

@lodyai
Copy link
Copy Markdown
Contributor

@lodyai lodyai Bot commented May 31, 2026

Summary

This branch adds property-based coverage for the invariants introduced around
PR #315: IR cycle detection now has generated DAG, cycle, missing-dependency,
order-only exclusion, and insertion-order determinism checks; Ninja build-line
formatting now checks dependency separator ordering; and command interpolation
now checks placeholder substitution around backtick-delimited regions.

Closes #322.

It also centralizes the manifest placeholder tokens used by rendering and
interpolation so the tests and implementation share one source of truth.

Review walkthrough

Validation

  • cargo test --all-targets --all-features property_tests: passed, 11 property tests.
  • make check-fmt: passed.
  • make lint: passed.
  • make test: passed.
  • coderabbit review --agent: run after each review milestone; all substantive concerns were addressed before this PR was opened.

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @LodyAI[bot], you have reached your weekly rate limit of 2500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 31, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 56b0a21b-6867-42c4-b1ed-9911ac8ed24e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-322-property-tests-for-cycle-detection-ninja-separator-ordering-and-command-interpolation

Comment @coderabbitai help to get the list of available commands and usage tips.

codescene-delta-analysis[bot]

This comment was marked as outdated.

Add `proptest` coverage for cycle detection, Ninja dependency separator
ordering, and command interpolation placeholder handling.

Centralize manifest placeholder tokens so rendering and interpolation share
the same constants, and add shared path generation helpers for property
strategies.
@lodyai lodyai Bot force-pushed the issue-322-property-tests-for-cycle-detection-ninja-separator-ordering-and-command-interpolation branch from 1248aea to 147f587 Compare June 1, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add proptest property-based tests for cycle detection, Ninja separator ordering, and command interpolation

1 participant