Instrument config path resolution (#292)#329
Draft
lodyai[bot] wants to merge 1 commit into
Draft
Conversation
Add structured tracing around explicit configuration path selection, environment variable lookup, diagnostic layer collection, and explicit configuration load failures. Record selector and path fields so users can diagnose precedence and load failures without changing configuration behaviour.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch instruments config path resolution and explicit config loading so users can diagnose why a CLI flag,
NETSUKE_CONFIG,NETSUKE_CONFIG_PATH, or discovery path was selected.Closes #292.
Review walkthrough
src/cli/config_merge.rsto review the selector, environment, diagnostic collection, and explicit load failure tracing.Validation
make check-fmt: passedmake lint: passedmake test: passedcoderabbit review --agent: completed without returning findings after setup statusNotes
make fmtwas also attempted, but the Markdown lint phase reported existing line-length violations across unrelated documentation files. The Rust formatting check passed throughmake check-fmt.