Skip to content

Allow no_expect_outside_tests pending whitaker#311 #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leynos wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow no_expect_outside_tests pending whitaker#311 #156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,11 @@ target/%/$(TARGET): ## Build binary in debug or release mode
lint: ## Run Clippy and the Whitaker Dylint suite with warnings denied
RUSTDOCFLAGS="$(RUSTDOC_FLAGS)" $(CARGO) doc --no-deps
$(CARGO) clippy $(CLIPPY_FLAGS)
RUSTFLAGS="$(RUST_FLAGS)" $(WHITAKER) --all -- $(CARGO_FLAGS)
# TODO: drop -A no_expect_outside_tests once leynos/whitaker#311 is fixed:
# rolling suite build 4e8a8ab regressed the #[cfg(test)] companion-module
# exemption and flags expect() calls in test-only helper functions under
# src/**/tests/.
RUSTFLAGS="$(RUST_FLAGS) -A no_expect_outside_tests" $(WHITAKER) --all -- $(CARGO_FLAGS)

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the expect lint enabled outside tests

This command-line allowance applies to every target Whitaker checks, not only the #[cfg(test)] companion modules producing false positives. Consequently, newly introduced expect() calls in production code or shared fixtures can pass this part of the lint gate as well. Keep the lint strict by pinning the last working Whitaker suite or narrowly exempting only the affected test modules rather than disabling the lint for the whole invocation.

AGENTS.md reference: AGENTS.md:L273-L275

Useful? React with 👍 / 👎.


typecheck: ## Type-check the workspace
RUSTFLAGS="$(RUST_FLAGS)" $(CARGO) check $(CARGO_FLAGS) $(BUILD_JOBS)
Expand Down
Loading