📝 CodeRabbit Chat: Implement requested code changes - #83
📝 CodeRabbit Chat: Implement requested code changes#83coderabbitai[bot] wants to merge 3 commits into
Conversation
Intercept the first newline-delimited Agentic Control Protocol (ACP) `initialize` frame from protocol stdin and remove host-delegated `terminal` and `fs` capabilities before the container sees the metadata. Bound the first-frame inspection buffer so oversized or unterminated input streams forward promptly into the container instead of waiting indefinitely. Document the ACP masking trust boundary, add unit and BDD coverage, and mark roadmap Step 2.6.1 as complete.
Move ACP initialize masking helpers out of the protocol proxy module so the proxy loop stays focused and under the file-length budget. Keep ACP first-frame rewriting behind a protocol-session option so generic protocol sessions retain raw stdin forwarding semantics unless ACP masking is selected. Split ACP BDD scenario wiring out of the unit-test module, extend coverage for the first-frame-only contract, and document the current hosted-mode ACP masking scope while `podbot host` remains forthcoming.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @coderabbitai[bot], you have reached your weekly rate limit of 2500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
Important Review skippedThis PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
5faeb10 to
9a6a1bd
Compare
1 participant
Code changes was requested by @leynos.
The following files were modified:
docs/developers-guide.mddocs/users-guide.mdsrc/engine/connection/exec/acp_helpers.rssrc/engine/connection/exec/protocol_acp_tests.rs