Plan: Adopt shared df12-lints plugin - #17
Draft
lodyai[bot] wants to merge 2 commits into
Draft
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
leynos
changed the title
Plan the replacement of the in-repo oxlint plugin (tools/oxlint-plugin-df12) with the shared df12-lints package pinned at fe04adc, consuming it through the df12-lints/oxlint-plugin export. The plan preserves the four df12/ rules and the .jsdoc-baseline.json suppressions, gating the switch on a before/after oxlint output diff. It also records the deployment concerns and behavioural discrepancies in the shared package (broken "." export in git installs, missing LICENSE, unpublished/private package, removed baseline caching, process.cwd vs context.cwd resolution, new baseline diagnostics, and maxLogicalOperators validation) so they can be filed as upstream bugs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The guidance document carried 77 unwrapped prose paragraphs that failed the repository's markdownlint MD013 line-length gate (the convention every other doc follows). markdownlint is a local-only gate, not part of CI's `make all`, which is how the unwrapped file landed. Reflow only the over-length paragraph lines to 80 columns, leaving code fences, tables, headings, and lists untouched and keeping long tokens unbroken. The change is content-preserving: the whitespace-insensitive token stream is identical to the previous version. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
lodyai
Bot
force-pushed
the
docs/adopt-shared-df12-lints
branch
from
June 15, 2026 23:36
4e2062e to
7aac523
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a DRAFT ExecPlan,
docs/execplans/use-shared-df12-lints.md, planning thereplacement of the in-repo oxlint plugin (
tools/oxlint-plugin-df12) with theshared
df12-lintspackage pinned atfe04adc80cfd8d3fc3df987f8022863a2f27a2a0, consumed via thedf12-lints/oxlint-pluginexport.The plan preserves the four
df12/rules and the 83-entry.jsdoc-baseline.jsonsuppressions, gating the switch on a before/afteroxlintoutput diff. It includes the mandatory living sections and a list ofdeployment concerns and behavioural discrepancies to file upstream against
df12-lints.This PR is plan-only; no implementation has been performed yet (awaiting
approval per the ExecPlan approval gate).
Upstream discrepancies identified (for filing against df12-lints)
.export in git installs (dist/is git-ignored, nopreparebuild script)LICENSEfile despitepackage.jsondeclaring ISCprivate: true/ unpublished — forces commit-pinned git installsfileswhitelist inpackage.jsonloadBaseline()now returns a result object, not aSetprocess.cwd()tocontext.cwd.jsdoc-baseline.jsonnow emits a diagnostic instead of being swallowedcomplex-conditionalmaxLogicalOperatorsis now validated/coercedIncidental fix
Wraps the pre-existing
docs/mocking-services-...mdguidance document to 80columns so the repo's local
make markdownlintgate passes. The change iscontent-preserving (whitespace-insensitive token stream identical to before);
only over-length prose paragraphs were reflowed.
Validation
make markdownlint— 0 errors across 16 filesmake nixie— all diagrams validated🤖 Generated with Claude Code