Add graph-slice property tests (#117) - #149
Draft
leynos wants to merge 1 commit into
Draft
Conversation
Cover the `observe graph-slice` budget, spillover, ordering, and same-file deduplication invariants with `proptest` cases. Drive the deduplication invariant both through the handler response and through `discover_same_file_cards` so duplicate `symbol_id` values are caught at the discovery boundary and in serialized output.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch adds property-based coverage for the
observe graph-sliceinvariants raised in issue #117. It verifies card-budget limits, spillover truncation, deterministic ordering and same-file card deduplication across generated inputs.Closes #117.
Review walkthrough
Validation
make check-fmt: passedmake lint: passedmake test: passed, 1439 tests passed and 4 skippedcoderabbit review --agent: passed with 0 findings after addressing the earlier proptest assertion concernNotes
The integration-style deduplication coverage drives both the serialized handler response and the
discover_same_file_cardsboundary. This keeps the property focused on the discovery invariant while still checking the response path that callers consume.