Catalogue front-end source authority (frontend-0.1.1)#355
Draft
leynos wants to merge 8 commits into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Reviewer's GuideAdds a detailed execution plan (ExecPlan) document describing how to design, implement, validate, and accept a front-end source authority catalogue for roadmap item 0.1.1, without yet adding the catalogue itself or changing runtime behaviour. Flow diagram for implementing the front-end source authority catalogue (flow diagram)flowchart LR
A[ExecPlan approved] --> B[Create docs/frontend-source-authority-catalogue.md]
B --> C[Classify sources by topic
platform, data, UX state, API,
styling, accessibility,
localization, testing]
C --> D[Mark each topic
authoritative or needs_reconciliation]
D --> E[Update docs/frontend-roadmap.md
item 0.1.1]
D --> F[Update docs/developers-guide.md
if workflow changes]
E --> G[Run validation
make fmt, markdownlint, nixie,
check-fmt, lint, test]
G --> H[Run css-view and Playwright
or record no executable UI]
H --> I[Run coderabbit review --agent
and resolve in-scope concerns]
I --> J[Commit with git commit -F
and push branch]
J --> K[Open or update
implementation pull request]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Owner
Author
|
@coderabbitai Please investigate the cause of the following issue using codegraph exploration and research, identify a fix and provide an AI coding agent prompt for the fix: |
This comment was marked as resolved.
This comment was marked as resolved.
Owner
Author
|
@coderabbitai Please investigate the cause of the following issue using codegraph exploration and research, identify a fix and provide an AI coding agent prompt for the fix: |
This comment was marked as resolved.
This comment was marked as resolved.
Owner
Author
|
@coderabbitai Please investigate the cause of the following issue using codegraph exploration and research, identify a fix and provide an AI coding agent prompt for the fix: |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Add the draft ExecPlan for roadmap item 0.1.1 so the source authority catalogue can be reviewed before implementation starts. Record the approval gate, source ownership strategy, validation expectations, Wyvern findings, Firecrawl checks, and current tooling constraints.
Add the front-end source authority catalogue for roadmap item 0.1.1 so later implementation tasks can cite an owning document or a named reconciliation follow-up. Mark the roadmap item complete and point contributor documentation at the new catalogue. Correct the front-end build target in the developers' guide while updating that workflow section.
Mark the implementation ExecPlan complete after the catalogue commit, branch push, and draft pull request update finished.
Pin the embedded PostgreSQL binary release source used by backend test bootstrap to the Theseus binary repository when no override is already set. Keep existing `POSTGRESQL_RELEASES_URL` values intact so CI and local runs can still opt into a different source deliberately. Update `postgresql_embedded`, `pg-embed-setup-unpriv`, and the Makefile `pg_worker` install version together so the test runner does not keep using an older bootstrap helper while the backend depends on the newer crates.
Split the PostgreSQL embedded binary cache out of the Cargo cache in CI so `Cargo.lock` churn does not evict the downloaded server archive. Point `POSTGRESQL_RELEASES_URL` at the Theseus releases endpoint to keep test bootstrap downloads on the intended source. Keep the existing `GITHUB_TOKEN` and `PG_EMBEDDED_WORKER` test environment intact.
Align the `POSTGRESQL_RELEASES_URL` bootstrap comment with the CI timeout failure mode and keep the pinned Theseus releases endpoint explicit. Refresh `Cargo.lock` after rerunning the embedded PostgreSQL dependency update so the lockfile records the current resolver output.
Record the lockfile normalization produced by the required embedded Postgres dependency update so CI and local builds use the same resolved graph.
lodyai
Bot
force-pushed
the
frontend-0-1-1-front-end-source-authority-catalogue
branch
from
58d462f to
c21ed6f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Add a CI cache warm-up script that downloads the exact Theseus PostgreSQL archive, verifies its checksum, and populates the pg-embed-setup-unpriv binary cache before nextest starts. Cache both postgresql_embedded and pg-embed-setup-unpriv binary directories, and align CI nextest scheduling with the repository Makefile so first-use cluster bootstrap is serialized. Extend the pg-embed nextest group to cover the remaining PostgreSQL-backed integration binaries. Stabilize the audit exception property test by excluding Fast Check's intentional `Invalid Date` values from a property that exercises real calendar dates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements roadmap task
(frontend-0.1.1)by adding the front-end source authority catalogue and marking the roadmap entry complete.docs/frontend-source-authority-catalogue.mdwith per-topic authority classifications and named reconciliation follow-ups.docs/frontend-roadmap.mdto mark item 0.1.1 done and cite the catalogue.docs/developers-guide.mdanddocs/contents.mdso contributors can find the catalogue; also corrects the front-end build target tomake fe-build.docs/execplans/frontend-0-1-1-front-end-source-authority-catalogue.md.Validation
make fmt: passedmake markdownlint: passedmake nixie: passedcss-view --help: passed; no executable front-end surface changed, so there was no URL-backed UI for css-view or Playwright to exercisecoderabbit review --agent: passed with zero findingsmake check-fmt: passedmake lint: passedmake test: passedReferences
docs/execplans/frontend-0-1-1-front-end-source-authority-catalogue.mddocs/frontend-source-authority-catalogue.md