Skip to content

Branch for testing LeadManager#40

Open
Blubby24 wants to merge 10 commits into
release-v2.0from
test/leadManager
Open

Branch for testing LeadManager#40
Blubby24 wants to merge 10 commits into
release-v2.0from
test/leadManager

Conversation

@Blubby24
Copy link
Copy Markdown

Created a new branch and new file for testing LeadManager. Also created tests for TryAddLead.

@Blubby24
Copy link
Copy Markdown
Author

Two of the methods in LeadManager do not pass these test cases. I'm still looking into whether it is my tests or the methods themselves.

@Blubby24 Blubby24 linked an issue Oct 24, 2024 that may be closed by this pull request
@lhmcgann lhmcgann assigned lhmcgann, fernthao and Blubby24 and unassigned lhmcgann and fernthao Oct 28, 2024
@lhmcgann lhmcgann added HW and Stim Related to hardware and stimulation abstraction Resource Mgt Related to ID tracking, object comparison, data storage and access, and other resource management labels Oct 28, 2024
@lhmcgann lhmcgann requested review from fernthao and lhmcgann October 28, 2024 02:53
@Blubby24 Blubby24 changed the base branch from main to release-v2.0 October 28, 2024 21:29
Copy link
Copy Markdown
Owner

@lhmcgann lhmcgann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Just check the code coverage report. I think you just need a few more test cases

@lhmcgann lhmcgann removed the request for review from fernthao January 23, 2025 21:39
@lhmcgann lhmcgann assigned rsjakes and unassigned Blubby24 Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HW and Stim Related to hardware and stimulation abstraction Resource Mgt Related to ID tracking, object comparison, data storage and access, and other resource management

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test LeadManager

4 participants