Test/thread config#55
Open
AlbertOpus2507 wants to merge 3 commits into
Open
Conversation
lhmcgann
requested changes
Nov 18, 2024
Owner
lhmcgann
left a comment
lhmcgann
left a comment
There was a problem hiding this comment.
Comments here are just on adding comments. Will review the test cases in more detail once those are added
| /// </summary> | ||
| public static IEnumerable<object[]> ConstructorTestData => new List<object[]> | ||
| { | ||
| new object[] |
Owner
There was a problem hiding this comment.
Add quick in-line comments just explaining what this test case is supposed to be, i.e., why did you pick the data values you did? What are you testing with it?
Owner
There was a problem hiding this comment.
Als similar in-line comments throughout your test method bodies must to make it super clear to readers what you're intending to do in that check
| /// <summary> | ||
| /// Unit tests for the ThreadConfigDataPerStimulator record. | ||
| /// </summary> | ||
| public class ThreadConfigDataPerStimulatorTest |
Owner
There was a problem hiding this comment.
Overall, nice naming and doc-commenting of methods! Can you add a doc-comment for the source class itself, too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test cases for constructor for ThreadConfigDataPerStimulator