Test String Hierarchy Body Model Builder#73
Open
cld99 wants to merge 8 commits into
Open
Conversation
lhmcgann
approved these changes
Apr 24, 2025
Owner
lhmcgann
left a comment
lhmcgann
left a comment
There was a problem hiding this comment.
Great job! Just added a couple small test cases, comments, and cleanup!
| if (StringHierarchySpec.TryParseOptionedRegionName( | ||
| parentOptionedRegionSpec, out _, out string optionStr) && | ||
| this._availableBaseRegions.TryGetValue(parentOptionedRegionSpec, | ||
| out var region)) |
Owner
There was a problem hiding this comment.
Just out of curiosity: why flip these two? what broke?
Owner
There was a problem hiding this comment.
flipped so the parsing happened even if parentOptionedRegionSpec not in available base regions. both orders work, this one just easier for testing
| } | ||
| catch (System.Reflection.TargetInvocationException e) | ||
| { | ||
| throw e.InnerException; |
Owner
There was a problem hiding this comment.
again just curious: why the inner exception?
Owner
There was a problem hiding this comment.
whenever an exception is thrown in a reflective call, it wraps the exception, so need to unwrap it to see them
lhmcgann
force-pushed
the
test/string-hierarchy-body-model-builder
branch
from
c25c61c to
69ed547
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.