Skip to content

py3 compatibility of basestring checks#47

Open
kristoff-it wants to merge 1 commit into
liberation:feature/django-19from
kristoff-it:feature/django-19
Open

py3 compatibility of basestring checks#47
kristoff-it wants to merge 1 commit into
liberation:feature/django-19from
kristoff-it:feature/django-19

Conversation

@kristoff-it
Copy link
Copy Markdown

aliased ‘basestring’ with ‘str’ for py3 compatibility

aliased ‘basestring’ with ‘str’ for py3 compatibility
@lauxley
Copy link
Copy Markdown
Contributor

lauxley commented Jun 28, 2016

Hi, thx for the PR
I'm a little bit confused as to why merge this in feature/django-19 which is not py3 compatible ?
Also this is not the preferred way to deal with basestring according to django's documentation https://docs.djangoproject.com/en/1.9/topics/python3/#string-handling-with-six

isinstance(myvalue, six.string_types)       # replacement for basestring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants