Skip to content

Feature/Sort fields and parent mapping#56

Open
vrcmarcos wants to merge 8 commits into
liberation:masterfrom
vrcmarcos:master
Open

Feature/Sort fields and parent mapping#56
vrcmarcos wants to merge 8 commits into
liberation:masterfrom
vrcmarcos:master

Conversation

@vrcmarcos
Copy link
Copy Markdown

@lauxley
Copy link
Copy Markdown
Contributor

lauxley commented Aug 18, 2016

hi, thx for the pr !
I just did a quick pass on the code and it looks cool but i have a few remarks:

  • would it be possible to make a PR for each feature ? (sort fields and parent mapping)
  • I'm wondering if parents mapping isn't out of scope for this package, what problem does it solve ?
  • no test for sorting fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants