update dependencies#52
Conversation
01f9ed1 to
90d2fd9
Compare
| log::error!("Failed to create SCDynamicStore"); | ||
| return; |
There was a problem hiding this comment.
Shouldn't we return the error here? IfWatcher::new (which calls background_task) already returns a Result, so we could propagate it to the user.
There was a problem hiding this comment.
yeah but it calls background_task inside a spawned thread not in the context of the new function itself
There was a problem hiding this comment.
True. But we could split it into, e.g., create_task and run_task or sth like that. I would prefer if we don't just silently fail (apart from the log msg).
There was a problem hiding this comment.
ah right, yeah that would make sense, I tried it but CFRunLoopSource is !Send
There was a problem hiding this comment.
Discussed out of band. New solution of handling the a failing background_task by polling rx in poll_if_event lgtm!
| log::error!("Failed to create SCDynamicStore"); | ||
| return; |
There was a problem hiding this comment.
Discussed out of band. New solution of handling the a failing background_task by polling rx in poll_if_event lgtm!
|
Thanks for updating dependencies, is there a new release planned here? |
Released |
Linux (
linux.rs):The
netlink-packet-routecrate renamednlas::Nla(NetLink Attributes) toAddressAttribute, and its new API directly containsstd::net::IpAddrinstead of raw bytes, eliminating the need to manually parse byte arrays and check the address family.Apple (
apple.rs):The
system-configurationcrate changedSCDynamicStoreBuilder::build()andSCDynamicStore::create_run_loop_source() to returnOption<T>instead ofTdirectly.Windows (
win.rs):The windows crate changed
NotifyIpInterfaceChange()andCancelMibChangeNotify2()to returnWIN32_ERRORdirectly instead ofResult<()>, requiring a call to.ok()to convert to aResult.Additionally, theBOOLEANwrapper type was replaced with native bool.I plan to release a patch release after this gets merged