Skip to content

update dependencies#52

Merged
jxs merged 1 commit intolibp2p:masterfrom
jxs:update-deps
Feb 16, 2026
Merged

update dependencies#52
jxs merged 1 commit intolibp2p:masterfrom
jxs:update-deps

Conversation

@jxs
Copy link
Copy Markdown
Member

@jxs jxs commented Feb 11, 2026

Linux (linux.rs):

The netlink-packet-route crate renamed nlas::Nla (NetLink Attributes) to AddressAttribute, and its new API directly contains std::net::IpAddr instead of raw bytes, eliminating the need to manually parse byte arrays and check the address family.

Apple (apple.rs):

The system-configuration crate changed SCDynamicStoreBuilder::build() and SCDynamicStore::create_run_loop_source() to return Option<T> instead of T directly.

Windows (win.rs):

The windows crate changed NotifyIpInterfaceChange() and CancelMibChangeNotify2() to return WIN32_ERROR directly instead of Result<()>, requiring a call to .ok() to convert to a Result. Additionally, the BOOLEAN wrapper type was replaced with native bool.

I plan to release a patch release after this gets merged

@jxs jxs requested a review from elenaf9 February 11, 2026 15:31
@jxs jxs force-pushed the update-deps branch 3 times, most recently from 01f9ed1 to 90d2fd9 Compare February 12, 2026 11:04
Comment thread src/apple.rs
Comment on lines +144 to +145
log::error!("Failed to create SCDynamicStore");
return;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we return the error here? IfWatcher::new (which calls background_task) already returns a Result, so we could propagate it to the user.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah but it calls background_task inside a spawned thread not in the context of the new function itself

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. But we could split it into, e.g., create_task and run_task or sth like that. I would prefer if we don't just silently fail (apart from the log msg).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah right, yeah that would make sense, I tried it but CFRunLoopSource is !Send

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed out of band. New solution of handling the a failing background_task by polling rx in poll_if_event lgtm!

Comment thread src/apple.rs
Copy link
Copy Markdown
Member

@elenaf9 elenaf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Comment thread src/apple.rs
Comment on lines +144 to +145
log::error!("Failed to create SCDynamicStore");
return;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed out of band. New solution of handling the a failing background_task by polling rx in poll_if_event lgtm!

@jxs jxs merged commit d99b46b into libp2p:master Feb 16, 2026
7 checks passed
@nazar-pc
Copy link
Copy Markdown

nazar-pc commented Mar 1, 2026

Thanks for updating dependencies, is there a new release planned here?
Patch version would be nice since API wasn't affected.

@elenaf9
Copy link
Copy Markdown
Member

elenaf9 commented Mar 3, 2026

Thanks for updating dependencies, is there a new release planned here? Patch version would be nice since API wasn't affected.

Released v3.2.2: #53 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants