Conversation
Node 26 becomes Active LTS in October; move the Docker build stage and the GitHub Actions workflows from Node 22 to 26. - Dockerfile: Node 26 no longer bundles corepack; install it from npm so packageManager in package.json still pins pnpm. - @types/node ^26.
Merging to main no longer publishes anything. Pushing a v* tag deploys to GitHub Pages and pushes ghcr.io/libreble/bikefit as <version>, <major>.<minor> and latest. Pull requests still build and smoke-test the image; the Pages workflow can still be run by hand from main.
deploy.yml and docker.yml become release.yml. A single job installs once and builds on the runner, uploads the Pages artifact and builds the image from the prebuilt output (new Dockerfile target `prebuilt`, fed via --build-context dist=...). The arm64 image no longer runs an emulated Node build. Building the Dockerfile from source (the default target) is unchanged for self-hosters.
mannes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the Docker build stage and the workflows from Node 22 to Node 26 (Active LTS from October).
packageManager in package.json still pins pnpm.
Tested locally in
node:26-alpine: image builds and passesdocker/smoke.sh.Release on
v*tags (second commit): merging tomainno longer publishes. Pushing av*tag deploys Pages and pushesghcr.io/libreble/bikefitas<version>,<major>.<minor>andlatest(thesha-*and main-latesttags are gone). PRs still build + smoke-test the image. Thegithub-pagesenvironment now allowsv*tags as well asmain.One release workflow (third commit):
deploy.yml+docker.yml→release.yml. One job installs once, builds on the runner (once — the relative build serves both), uploads the Pages artifact, and builds the image from that output via the new Dockerfile targetprebuilt(--build-context dist=…). No more emulated Node build for arm64.docker build .from source is unchanged. Verified locally: Pages base paths, prebuilt image smoke test, arm64 prebuilt build, from-source build.