Invite device reports via pre-filled GitHub issues - #3
Merged
Merged
Conversation
A dismissible toast, never in the way: - a brush that isn't an iO (the one confirmed line) connects: asks once per model whether it works and opens the device-report issue form pre-filled with model id, protocol, firmware and the GATT layout. No brushing data, no characteristic values, no raw frames. - the chooser is dismissed or connecting fails: offers the connection-problem form. The app sends nothing itself; the user reviews and submits on GitHub.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brushlog is only confirmed on the Oral-B iO. This asks everyone else to tell us how their brush behaves, without getting in the way.
What the user sees
A dismissible, non-blocking toast (bottom right):
Both open a pre-filled GitHub issue form in a new tab. The app sends nothing itself; the user reviews and submits on GitHub.
What's in the report
Connected: advertised name, model id / protocol / firmware, service and characteristic UUIDs with their properties, and the browser. No brushing data, no characteristic values, no raw frames. If we need a capture, we ask for the Diagnostics report in the thread.
Connection problem: the browser and the error message, if there was one.
Changes
.github/ISSUE_TEMPLATE/device-report.ymlandconnection-problem.yml(labelsdevice report/connection problem, both created)src/lib/report.tsbuilds the issue URLs;src/components/ReportToast.tsxshows the toastuseBrushexposescancelled(the last connect ended with the chooser dismissed)Testing
npm run typecheckandnpm run buildpassThe forms only resolve on
main, so the pre-filled links fall back to the plain issue picker until this merges.