Config: Convert Ozone 'Color Theme' setting to array - #19451
Open
Ryunam wants to merge 1 commit into
Open
Conversation
Ryunam
force-pushed
the
array-ozone-color-theme
branch
from
August 22, 2026 14:12
514f77d to
b5844c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR proposes a conversion of the Ozone "Color Theme" setting (which was previously based on integers) to an array-based setting, using string identifiers instead of numerical values (ie
"basic_white"instead of"0").I've been thinking about introducing this type of change for a long time, ever since discussing the viability of it with jdgleaver back in 2021. The main advantages are the following:
Most importantly, this conversion is backwards-compatible and will not break existing configs. The code in
configuration.ctakes care of reading legacy numeric values assigned to Ozone themes (if present in the user's config file), setting the desired theme as expected, then converting that legacy number in the config file to the new string-based value.Reviewers
@LibretroAdmin