Skip to content

Implement setting to force flash size - #268

Open
tau- wants to merge 1 commit into
libretro:masterfrom
tau-:flash-bank-cnt-config
Open

Implement setting to force flash size#268
tau- wants to merge 1 commit into
libretro:masterfrom
tau-:flash-bank-cnt-config

Conversation

@tau-

@tau- tau- commented Nov 14, 2024

Copy link
Copy Markdown

Adds libretro setting to toggle between automatic detection and fixed sizes for the cartidge flash. Allows for selection of "auto", "64kb", and "128kb" options. This allows for compatibility with roms which need a specific amount of memory but do not appear in the list of known overrides.

Adds libretro setting to toggle between automatic detection and fixed sizes for the cartidge flash. Allows for selection of "auto", "64kb",  and "128kb" options. This allows for compatibility with roms which need a specific amount of memory but do not appear in the list of known overrides.
@tau-
tau- force-pushed the flash-bank-cnt-config branch from 5b995ba to bf1212b Compare November 14, 2024 12:34
@saulfabregwiivc

Copy link
Copy Markdown

Very nice :)

@davidgfnet

Copy link
Copy Markdown
Collaborator

I will check this out, please do not merge it just yet.
Also, I plan to update the gba_overrides file using some repo I created, to have a proper completi-sh list of games and their config.

@davidgfnet

Copy link
Copy Markdown
Collaborator

Hey, mind telling me which games do you think this would be useful for?
Also would be better to have a setting to force a storage type and size. As of today only these exist:
None, SRAM (32KB), EEPROM (512bytes / 8KB), FLASH (64 / 128KB). It might be just easier to have an option to select among those ones.

@tau-

tau- commented Jan 8, 2025

Copy link
Copy Markdown
Author

I originally implemented this to support various rom hacks which are not listed in the overrides list (as they may have modified headers) but require 128kb of cartridge flash to function. Generally I think having a way to manually select this option would be great for allowing combability with homebrew. This could be reworked as you described to allow selecting from a small list of known cartridge configurations, but I did not look carefully into the SRAM and EEPROM emulation, so I will leave this open for now if you have additional feedback.

@saulfabregwiivc

Copy link
Copy Markdown

is this still being worked on? it's so neat of having an option to set custom save size.

@davidgfnet

Copy link
Copy Markdown
Collaborator

I dont like it the way it's implemented.
I think I will add some core option to force save type (not save size), so that there's more flexibility.
I am also considering not matching games (in gba_over) based on title, only on game ID. That would save all the useless titles that take up some space and improve compatibility with some romhacks out there that patch the title :P
Will send some commits soon, im working on other features as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants