Add SDL_SHADERCROSS_PROP_HLSL_SKIP_SPIRV_ROUNDTRIP_BOOLEAN to opt out of SPIRV roundtrip#204
Merged
Merged
Conversation
Contributor
Author
|
Bump for visibility– |
|
I would love for this to get merged |
thatcosmonaut
approved these changes
Apr 6, 2026
Collaborator
|
Looks good, could we add a note that this shouldn't be used with Stuctured Buffers in the prop comment? Also requesting comment from @madebr |
madebr
approved these changes
Apr 6, 2026
madebr
left a comment
Contributor
There was a problem hiding this comment.
My only comment would've been about API design and long-term stability, but a property is very non-intrusive.
Contributor
Author
|
Thanks guys! I'll add the note and we can get this merged. |
Added a note about avoiding the property when using Structured Buffers.
Collaborator
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Some HLSL constructs survive the SPIRV roundtrip without issue, and for those cases the roundtrip adds unnecessary compile time and an extra SPIRV-Cross transformation. This adds a property that lets callers opt out when they know their HLSL is clean.
Changelog
SDL_SHADERCROSS_PROP_HLSL_SKIP_SPIRV_ROUNDTRIP_BOOLEANto SDL_shadercross.hNotes
Callers should only set this property if their HLSL does not rely on constructs that require SPIRV normalization, such as Structured Buffers. Incorrect use may produce invalid or unexpected output.
References
#202
#203