feat: add listen address configuration option by yingzeliangzi · Pull Request #94 · lich0821/ccNexus

yingzeliangzi · 2026-01-15T05:41:00Z

目前项目默认监听0.0.0.0公网ip且未定义auth_token 新增自定义监听地址并设置默认监听127.0.0.1 防止未经授权的公网访问

Copilot

Pull request overview

This PR adds configurable listen address support to improve security by defaulting to localhost (127.0.0.1) instead of binding to all interfaces (0.0.0.0). This prevents unauthorized public network access when no auth_token is configured.

Changes:

Added ListenAddr field to configuration with 127.0.0.1 as the default
Created UpdateNetwork method to update both port and listen address atomically
Updated UI to display and configure listen address with preset buttons for common values

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
internal/config/config.go	Added ListenAddr field, getter/setter methods, validation, and storage persistence
internal/service/settings.go	Added UpdateNetwork method and listen address validation in UpdateConfig
internal/proxy/proxy.go	Modified server startup to bind to configured listen address instead of all interfaces
cmd/server/main.go	Added environment variable support for CCNEXUS_LISTEN_ADDR and updated logging
cmd/server/webui/api/config.go	Updated API endpoints to handle listen address in requests/responses
cmd/server/webui/ui/js/api.js	Modified updatePort to accept optional listenAddr parameter
cmd/desktop/app.go	Added UpdateNetwork method wrapper
cmd/desktop/frontend/wailsjs/*	Generated Wails bindings for UpdateNetwork method
cmd/desktop/frontend/src/*.js	Updated UI to support listen address configuration with presets
cmd/desktop/frontend/src/i18n/*.js	Added translations for listen address UI elements
cmd/desktop/frontend/src/style.css	Added CSS styles for listen address preset buttons

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-15T05:43:56Z

cmd/desktop/frontend/src/modules/modal.js

        return;
    }

+    if (!listenAddr || /\s/.test(listenAddr)) {


The validation only checks for empty values and whitespace. Consider validating that the listen address is a valid IP address or hostname. Invalid addresses like "999.999.999.999" or malformed hostnames will pass this check and only fail at runtime when the server attempts to bind.

Copilot · 2026-01-15T05:43:56Z

internal/config/config.go

+	if strings.TrimSpace(c.ListenAddr) == "" {
+		return fmt.Errorf("invalid listen address")
+	}


The validation only checks for empty/whitespace values but does not verify that the address is a valid IP address or hostname. Consider using net.ParseIP or similar validation to ensure the listen address is valid before attempting to bind to it. This would provide better error messages at configuration time rather than runtime.

Copilot · 2026-01-15T05:43:56Z

cmd/server/webui/api/config.go

+		if strings.TrimSpace(req.ListenAddr) == "" {
+			WriteError(w, http.StatusBadRequest, "Invalid listen address")
+			return
+		}


The validation only checks for empty/whitespace values but does not verify that the address is a valid IP address or hostname. Consider adding proper validation to ensure the listen address format is valid before saving it to configuration.

Copilot · 2026-01-15T05:43:57Z

internal/service/settings.go

+	if strings.TrimSpace(listenAddr) == "" {
+		return fmt.Errorf("invalid listen address")
+	}


The validation only checks for empty/whitespace values. Consider adding validation to ensure the listen address is a valid IP address or hostname format using net.ParseIP or similar methods.

Copilot · 2026-01-15T05:43:57Z

cmd/desktop/frontend/src/i18n/zh-CN.js

+        listenAddrLabel: '监听地址：',
+        listenAddrPlaceholder: '例如：127.0.0.1',
+        listenAddrPresetPublic: '公网 0.0.0.0',
+        listenAddrPresetLAN: '局域网 192.168.0.0',


The preset value '192.168.0.0' is a network address, not a valid host IP to bind to. This should likely be '192.168.0.1' or another valid host address in the private range. Binding to .0.0 addresses (network addresses) may fail or produce unexpected behavior depending on the OS.

Suggested change

listenAddrPresetLAN: '局域网 192.168.0.0',

listenAddrPresetLAN: '局域网 192.168.0.1',

Copilot · 2026-01-15T05:43:57Z

cmd/desktop/frontend/src/i18n/en.js

+        listenAddrLabel: 'Listen address:',
+        listenAddrPlaceholder: 'e.g., 127.0.0.1',
+        listenAddrPresetPublic: 'Public 0.0.0.0',
+        listenAddrPresetLAN: 'LAN 192.168.0.0',


The preset value '192.168.0.0' is a network address, not a valid host IP to bind to. This should likely be '192.168.0.1' or another valid host address in the private range. Binding to .0.0 addresses (network addresses) may fail or produce unexpected behavior depending on the OS.

Suggested change

listenAddrPresetLAN: 'LAN 192.168.0.0',

listenAddrPresetLAN: 'LAN 192.168.0.1',

Copilot · 2026-01-15T05:43:58Z

cmd/desktop/frontend/src/modules/ui.js

+						<input type="text" id="listenAddrInput" placeholder="${t('modal.listenAddrPlaceholder')}">
+						<div class="listen-addr-presets">
+							<button class="preset-chip" onclick="window.setListenAddrPreset('0.0.0.0')">${t('modal.listenAddrPresetPublic')}</button>
+							<button class="preset-chip" onclick="window.setListenAddrPreset('192.168.0.0')">${t('modal.listenAddrPresetLAN')}</button>


The preset value '192.168.0.0' is a network address, not a valid host IP to bind to. This should likely be '192.168.0.1' or use '0.0.0.0' to bind to all interfaces on the local machine. Network addresses ending in .0.0 are typically reserved and may not bind correctly.

Suggested change

<button class="preset-chip" onclick="window.setListenAddrPreset('192.168.0.0')">${t('modal.listenAddrPresetLAN')}</button>

<button class="preset-chip" onclick="window.setListenAddrPreset('192.168.0.1')">${t('modal.listenAddrPresetLAN')}</button>

Copilot · 2026-01-15T05:43:58Z

cmd/desktop/frontend/src/modules/modal.js

 import { t } from '../i18n/index.js';
 import { escapeHtml } from '../utils/format.js';
-import { addEndpoint, updateEndpoint, removeEndpoint, testEndpoint, testEndpointLight, updatePort } from './config.js';
+import { addEndpoint, updateEndpoint, removeEndpoint, testEndpoint, testEndpointLight, updateNetwork } from './config.js';


Unused import testEndpoint.

Suggested change

import { addEndpoint, updateEndpoint, removeEndpoint, testEndpoint, testEndpointLight, updateNetwork } from './config.js';

import { addEndpoint, updateEndpoint, removeEndpoint, testEndpointLight, updateNetwork } from './config.js';

lich0821 · 2026-01-16T01:32:44Z

@hea7enn 佬怎么看？

hea7enn · 2026-01-17T02:56:21Z

本身就是本地代理服务，无需考虑公网问题，直接关闭吧

yingzeliangzi · 2026-01-17T03:10:38Z

不过我这边测试如果有公网ip 确实可以无授权访问使用的

hea7enn · 2026-01-17T03:18:47Z

但是个人电脑一般也不会专门去开个公网，还提供地址给别人，这种极小概率事件没必要还单独做个功能，不太实用

feat: add listen address configuration option

8b3d0ba

Copilot AI review requested due to automatic review settings January 15, 2026 05:41

Copilot started reviewing on behalf of yingzeliangzi January 15, 2026 05:41 View session

Copilot AI reviewed Jan 15, 2026

View reviewed changes

yingzeliangzi closed this Jan 17, 2026

	listenAddrPresetLAN: '局域网 192.168.0.0',
	listenAddrPresetLAN: '局域网 192.168.0.1',

	listenAddrPresetLAN: 'LAN 192.168.0.0',
	listenAddrPresetLAN: 'LAN 192.168.0.1',

	<button class="preset-chip" onclick="window.setListenAddrPreset('192.168.0.0')">${t('modal.listenAddrPresetLAN')}</button>
	<button class="preset-chip" onclick="window.setListenAddrPreset('192.168.0.1')">${t('modal.listenAddrPresetLAN')}</button>

	import { addEndpoint, updateEndpoint, removeEndpoint, testEndpoint, testEndpointLight, updateNetwork } from './config.js';
	import { addEndpoint, updateEndpoint, removeEndpoint, testEndpointLight, updateNetwork } from './config.js';

Conversation

yingzeliangzi commented Jan 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

lich0821 commented Jan 16, 2026

Uh oh!

hea7enn commented Jan 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yingzeliangzi commented Jan 17, 2026

Uh oh!

hea7enn commented Jan 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hea7enn commented Jan 17, 2026 •

edited

Loading