Skip to content

feat: Bump Chromicons to v3.13.0#149

Merged
dexterca merged 1 commit into
masterfrom
bump-chromicons-v3.13.0
May 15, 2026
Merged

feat: Bump Chromicons to v3.13.0#149
dexterca merged 1 commit into
masterfrom
bump-chromicons-v3.13.0

Conversation

@dexterca
Copy link
Copy Markdown
Member

@dexterca dexterca commented May 15, 2026

Summary

  • Bump @lifeomic/chromicons from ^3.12.0 to ^3.13.0 and refresh yarn.lock.
  • Add search metadata for new sparkle icons (SparkleFilter, SparkleOutput, SparkleSelect) so they behave like existing icons on chromicons.com.

Test plan

  • Run yarn install locally (lockfile was updated from registry metadata without a full install in this environment).
  • Run yarn dev and confirm the icon grid loads and new sparkle icons appear with correct names and search keywords.
  • Run yarn build before deploy if that is part of your release checklist.

Made with Cursor

Add site metadata for new sparkle filter, output, and select icons.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cursor
Copy link
Copy Markdown

cursor Bot commented May 15, 2026

PR Summary

Low Risk
Low risk dependency bump plus added icon search metadata; main risk is minor UI/search regressions if icon exports or names changed in @lifeomic/chromicons v3.13.0.

Overview
Updates @lifeomic/chromicons from ^3.12.0 to ^3.13.0 and refreshes yarn.lock to match the new package version.

Extends src/util/metadata.js with search keywords/categories for the newly added sparkle icons (SparkleFilter, SparkleOutput, SparkleSelect) so they appear and are searchable like existing icons.

Reviewed by Cursor Bugbot for commit e1755d6. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread src/util/metadata.js
Copy link
Copy Markdown

@lifeomic-review-bot lifeomic-review-bot Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment

This updates @lifeomic/chromicons to ^3.13.0 and extends the static icon metadata map so SparkleFilter, SparkleOutput, and SparkleSelect get keywords and categories consistent with neighboring sparkle icons—the same pattern used elsewhere in src/util/metadata.js and consumed from src/pages/index.js via metadata[icon]?.keywords. PR scope matches the listed changes: dependency line, metadata, and lockfile refresh.

[suggestion] See inline note on guarding metadata keys against upstream export naming.

Tests

No automated tests were added; given a data-only metadata change and a minor dependency line bump, relying on manual smoke (yarn dev / grid load) per the PR test plan is reasonable. Adding a brittle test that parses the Chromicons export list would be optional and not merge-blocking here.

CI

Required checks were still pending in the snapshot; merge remains gated by branch protection, so this approval does not depend on seeing final green.

Not reviewed (per changedFiles): security, performance.

Bugbot: no blocking threads — no action.

Residual risks / follow-ups

  • Completing yarn install and a quick yarn build locally is worthwhile because the PR notes the lockfile was refreshed without a full install in that environment.
  • If @lifeomic/chromicons 3.13.0 renamed any of these components, affected icons would still appear from the namespace import but would miss the new search metadata until keys are corrected.

This review was generated by review-bot.

@dexterca dexterca requested review from sternetj and xdumaine May 15, 2026 16:14
@dexterca dexterca merged commit 73028f1 into master May 15, 2026
4 checks passed
@dexterca dexterca deleted the bump-chromicons-v3.13.0 branch May 15, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant