feat: Bump Chromicons to v3.13.0#149
Conversation
Add site metadata for new sparkle filter, output, and select icons. Co-authored-by: Cursor <cursoragent@cursor.com>
PR SummaryLow Risk Overview Extends Reviewed by Cursor Bugbot for commit e1755d6. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Assessment
This updates @lifeomic/chromicons to ^3.13.0 and extends the static icon metadata map so SparkleFilter, SparkleOutput, and SparkleSelect get keywords and categories consistent with neighboring sparkle icons—the same pattern used elsewhere in src/util/metadata.js and consumed from src/pages/index.js via metadata[icon]?.keywords. PR scope matches the listed changes: dependency line, metadata, and lockfile refresh.
[suggestion] See inline note on guarding metadata keys against upstream export naming.
Tests
No automated tests were added; given a data-only metadata change and a minor dependency line bump, relying on manual smoke (yarn dev / grid load) per the PR test plan is reasonable. Adding a brittle test that parses the Chromicons export list would be optional and not merge-blocking here.
CI
Required checks were still pending in the snapshot; merge remains gated by branch protection, so this approval does not depend on seeing final green.
Not reviewed (per changedFiles): security, performance.
Bugbot: no blocking threads — no action.
Residual risks / follow-ups
- Completing
yarn installand a quickyarn buildlocally is worthwhile because the PR notes the lockfile was refreshed without a full install in that environment. - If
@lifeomic/chromicons3.13.0 renamed any of these components, affected icons would still appear from the namespace import but would miss the new search metadata until keys are corrected.
This review was generated by review-bot.
Summary
@lifeomic/chromiconsfrom^3.12.0to^3.13.0and refreshyarn.lock.SparkleFilter,SparkleOutput,SparkleSelect) so they behave like existing icons on chromicons.com.Test plan
yarn installlocally (lockfile was updated from registry metadata without a full install in this environment).yarn devand confirm the icon grid loads and new sparkle icons appear with correct names and search keywords.yarn buildbefore deploy if that is part of your release checklist.Made with Cursor