chore: sync intent fillDeadline/expires with lifi-backend (EXP-432)#50
Conversation
Cross-chain orders now use fillDeadline=44h, expires=2d to match LIFI_INTENTS_FILL_DEADLINE_DURATION_SECONDS / LIFI_INTENTS_EXPIRES_DURATION_SECONDS from lifi-backend PR #8340. Same-chain orders continue to use 10m/10m, matching LIFI_INTENTS_SAMECHAIN_FILL_DEADLINE_DURATION_SECONDS.
📝 WalkthroughWalkthroughThe PR makes deadline calculations in the ChangesChain-aware deadline computation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🚀 Preview deployed! Worker: |
Apply fillDeadline=44h / expires=2d uniformly. Out-of-scope branching on isSameChain() removed.
|
🚀 Preview deployed! Worker: |
Summary
Bump
IntentfillDeadline from 2h → 44h and expires from 24h → 2d, mirroring lifi-backend PR #8340 (LIFI_INTENTS_FILL_DEADLINE_DURATION_SECONDS/LIFI_INTENTS_EXPIRES_DURATION_SECONDS).The change is two constants on the
Intentclass (src/lib/libraries/intent.ts:118-119); values are applied uniformly to every issued order viasinglechain()andmultichain().Linear: EXP-432
Backend PR: lifinance/lifi-backend#8340
Test plan
bun run test:unit— 25/25 (3 new tests undertests/unit/intent.test.tscovering cross-chain singlechain, same-chain singlechain, and multichain — all asserting fillDeadline=44h, expires=2d)bun run test:e2e— 3/3 (Chromium)bun run check— no new errors introduced (pre-existing env-var errors onmainunaffected)bun run lint— clean on touched filesin 44hin IntentList