fix(accessControl): propagate error details instead of returning null#30
Open
laciferin2024 wants to merge 1 commit intolighthouse-web3:mainfrom
Open
fix(accessControl): propagate error details instead of returning null#30laciferin2024 wants to merge 1 commit intolighthouse-web3:mainfrom
laciferin2024 wants to merge 1 commit intolighthouse-web3:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28
Summary
This patch updates access control error propagation so failed node responses include returned error details instead of always returning
error: null.Changes
src/methods/accessControl/index.tsto return collected node errors whenisSuccessis false.Validation
npm run buildnpm testNote
@ravish1729
-
errorsto the api response schema: to pass down all the errors.This would give us early indicators of eminent dangers like the 2013 chain fork of Bitcoin where older miners failed to process newer blocks even though the consensus was valid.