Repository navigation
Show the tick's camera frame in the projection strip. - #2749
horatiualmasan merged 1 commit into
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (6)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughCamera frame requests now use separate keyframe and log timestamps. The camera projection strip passes both values to the frame component, which includes both in the generated URL. ChangesCamera frame timestamp requests
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The projection strip now requests the tick’s camera frame using its matching keyframe. No actionable merge-blocking risk was established. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1bb760e to
79dfa67
Compare
79dfa67 to
cda5773
Compare
✅ Fast Track: all required checks passed — auto-approved.
To run the guardrails locally, from Reflects |
cda5773 to
ed460b1
Compare
The strip sends the tick's log time as well as its keyframe, so the image changes with the point cloud instead of repeating the keyframe.
ed460b1 to
87f51ec
Compare
What has changed and why?
The strip asked only for the keyframe, so the image stayed the same for about one group of pictures while the point cloud moved on every tick. This is the user-visible fix for LIG-11087. Depends on PR4.
Each selected camera tile sends keyframe_log_time_ns and log_time_ns from the tick.
Both times stay strings, so the nanosecond values are not rounded.
The image is requested only when the recording id and both times are present.
The channel picker is unchanged.
How has it been tested?
New tests
Did you update CHANGELOG.md?
Summary by CodeRabbit