multi: bump lnd to master, pin ANCHORS in custom_channels itest#2082
multi: bump lnd to master, pin ANCHORS in custom_channels itest#2082jtobin merged 2 commits intolightninglabs:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's lnd dependency to the latest master version to incorporate recent production taproot features. To maintain test stability, it also adjusts the custom_channels integration test to explicitly use ANCHORS as the commitment type, preventing conflicts with lnd's new default negotiation behavior for public channels. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates various dependencies in go.mod and go.sum, including a replacement of the lnd dependency with a specific fork. It also modifies the integration test harness to default the commitment type to anchors when unspecified, preventing public channels from failing due to taproot-final negotiation. A review comment suggests further targeting this change to only apply to public channels, allowing private channels to continue using lnd's default negotiation logic for testing purposes.
Coverage Report for CI Build 24671241280Coverage increased (+0.005%) to 34.362%Details
Uncovered Changes
Coverage Regressions24 previously-covered lines in 7 files lost coverage.
Coverage Stats
💛 - Coveralls |
jtobin
left a comment
jtobin
left a comment
There was a problem hiding this comment.
Looks like lightningnetwork/lnd#10763 landed, so probably worth retargeting the replace directive at the canonical repo? Also agree w/Dario's comment re: axing the release note entry. Otherwise LGTM! 👍 👍
Bump github.com/lightningnetwork/lnd to master tip (a8a3e13120eb) to pull in the production taproot work (PR #9985) along with the acceptor/RBF follow-ups from lnd#10763.
The implicit negotiation default in lnd's funding/commitment_type_negotiation.go now prefers SimpleTaprootFinal over anchors whenever both peers advertise the final feature bit, which is the default. Final-taproot channels are rejected if they are public (see funding/manager.go), and the "normal sats" channels in this harness carry gossip and must be public. Default the CommitmentType of any openChannelAndAssert caller that hasn't chosen one to ANCHORS so we keep the pre-bump behaviour without touching lnd's negotiation logic.
GeorgeTsagk
force-pushed
the
taproot-final-acceptor
branch
from
901df75 to
c8950f3
Compare
github-project-automation
Bot
moved this from 🆕 New
to 👀 In review
in Taproot-Assets Project Board
08c341f
github-project-automation
Bot
moved this from 👀 In review
to ✅ Done
in Taproot-Assets Project Board
4 participants
Description
Bumps lnd to master tip to pull in the production taproot work and pins ANCHORS as the default commitment type in
openChannelAndAssertso the custom_channels itest's public "normal sats" channels aren't swept up by lnd's new implicit-negotiation preference for final-taproot (which rejects public channels).Depends on lightningnetwork/lnd#10763