feat(sdk): add configurable media3 player builder - #127
Open
jonathancaudill wants to merge 1 commit into
Open
Conversation
Contributor
|
Excited to take a look at this! Hopefully will get a chance by EOW |
Contributor
|
I did a quick pass and I know @brunoro is doing the same since he's kinda owning the audio stuff. I've just got a few little API suggestions that I put up here: 5d073d2 Basically just made a base |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okie-dokie!
First draft of some more advanced audio capabilities. I can edit the description later as needed before merge.
So as it turns out, I forgot a crucial detail in #119 . The SDK sandbox blocks most stuff regarding Context. So a straight-up handoff isn't really feasible. Below is what I think will work pretty well, and it still honors the split.
SDK's default audio behavior and simple building of LightAudioPlayer instances is unchanged.
SDK will allow more advanced specs to be given when building an ExoPlayer instance via the configure argument. SDK will also allow tools to change aspects of the media3 pipeline live--queueing, etc. Which is good, because streaming requires a lot of small changes to be made as cell service comes and goes, as the user queues up tracks, etc.
SDK will also enforce one LightMediaEnv per tool & one SimpleCache object per directory.