fix: example tools qa - #129
Merged
Merged
Conversation
Contributor
|
I had previously left a comment about switching from java time libs to the kotlin ones. Pulled at that yarn and it's a good but out-of-scope change. Will do it on another PR |
dupontgu
approved these changes
Jul 28, 2026
| val enableKeyAnimation: Boolean, | ||
| val swipeEnabled: Boolean? | ||
| // optional for older sdk servers that omit this field | ||
| val swipeEnabled: Boolean? = null, |
Contributor
There was a problem hiding this comment.
This is good, but curious - did you have a crash or anything related to this? wanna make sure these nullable fields are safe to add by default.
Contributor
Author
There was a problem hiding this comment.
yes there is a crash without this!
Contributor
There was a problem hiding this comment.
ok gtk!! do you mind adding explicitNulls = false to lightJson before merging?
val lightJson = Json {
ignoreUnknownKeys = true
explicitNulls = false
}
just as an added safety measure, with the bonus side effect that it will shrink our payloads
allow kotlinx datetime as dependency, move weather tool to use it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QA as per Joe's requests:
Also fixes an error from sdk client-server version mismatch, and an issue where the scrollbar would flash when location search results returned less than 1 page of results.