perf: chunked-prefill prefix cache update for non-hybrid models#22
Open
LorrinWWW wants to merge 3 commits into
Open
perf: chunked-prefill prefix cache update for non-hybrid models#22LorrinWWW wants to merge 3 commits into
LorrinWWW wants to merge 3 commits into
Conversation
Contributor
Author
|
@XucSh Can you take a look for this one? thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The commit broadens what was InsertHybridCache (gated on hybrid_cache != nullptr — Mamba/hybrid only) into InsertPrefixCache (gated on kv_prefix_cache != nullptr). Before this fix, plain transformer models never inserted mid-chunk KV pages into the radix tree during chunked prefill, only hybrid models did. The function was renamed and the guard moved so non-hybrid models now also get prefix-cache updates per chunk.
Test Plan