Skip to content

Cap snprintf return value in mod_maxminddb to prevent stack over-read #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kodareef5 wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −0
Open

Cap snprintf return value in mod_maxminddb to prevent stack over-read #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/mod_maxminddb.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,9 +377,11 @@ geoip2_env_set (request_st * const r, array * const env,
break;
case MMDB_DATA_TYPE_DOUBLE:
vlen = snprintf(buf, sizeof(buf), "%.5f", data->double_value);
if (vlen >= sizeof(buf)) vlen = sizeof(buf) - 1;
break;
case MMDB_DATA_TYPE_FLOAT:
vlen = snprintf(buf, sizeof(buf), "%.5f", data->float_value);
if (vlen >= sizeof(buf)) vlen = sizeof(buf) - 1;
break;
case MMDB_DATA_TYPE_INT32:
vlen = li_itostrn(buf, sizeof(buf), data->int32);
Expand Down