Use php-dev.ini file for any PHP version#274
Open
rhea-machine wants to merge 2 commits intomasterfrom
Open
Conversation
rhea-machine
force-pushed
the
php-ini-anywhere
branch
2 times, most recently
from
e9b9988 to
b491339
Compare
rhea-machine
force-pushed
the
php-ini-anywhere
branch
from
b491339 to
9ca8b0c
Compare
sephii
suggested changes
Aug 18, 2019
| # notify: restart apache | ||
| # become: yes | ||
| - name: Configure mod-php | ||
| command: "{{ phpenmod }} {{ item }}" |
There was a problem hiding this comment.
Suggested change
| command: "{{ phpenmod }} {{ item }}" | |
| command: "{{ phpenmod }} php-dev" |
And remove the with_items below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The php.ini template was only used
if php_version < 7.0oros != debian.That doesn't make sense as a few variables having effect on it don't relate to any of those conditions. Also, I need some of those (like
php_upload_max_filesize) in our Moodle projects (using Debian and PHP >= 7.0).Therefore I propose to include it by default in the PHP role.