Refactored hline and rect functions to be converted into labels#2
Open
LeoPrissberg wants to merge 1 commit intomainfrom
Open
Refactored hline and rect functions to be converted into labels#2LeoPrissberg wants to merge 1 commit intomainfrom
LeoPrissberg wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts add_hline(), add_vrect(), and add_hrect() to convert annotations into labels. Similar to how add_vline() now converts to labels.
What’s included
Updated _process_multiple_axis_spanning_shapes()
Hline now creates a single labeled shape (maps: right→end, left→start, middle→middle).
Both vrect and hrect follow the same format for converting to labels.
Skips creating a layout.annotation for all functions
Note: Tests needs to be changed to work with labels instead of annotations