fix(planner): suppress audio stat for zero-duration title allocations#102
Merged
Conversation
Titles with no assigned asset (duration = 0) were getting `audio_bits_per_second` set to the 192 kbps silent-fallback rate from `estimate_title_audio_bitrate_bps`, causing the Planner to display "192 kbps audio" next to "No asset / 0:00" rows even though that audio is never counted in the budget estimate. Gate `audio_bits_per_second` on a real duration, matching the same `duration <= 0.0` guard that already zeroes out `bits_per_second` for these rows. Caught by Codex review on PR #101. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L3tSFK3P9vGwbNNtb4AYQG
Contributor
Author
|
@codex review |
1 similar comment
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex follow-up to #101.
Summary
Titles with no assigned asset (duration = 0) were getting
audio_bits_per_secondset to the 192 kbps silent-fallback rate fromestimate_title_audio_bitrate_bps, causing the Planner to display "192 kbps audio" next to "No asset / 0:00" rows even though that audio is never actually counted in the budget estimate.Fix: gate
audio_bits_per_secondonduration > 0, matching the same guard that already zeroes outbits_per_secondfor these rows inallocate_title_bitrates.Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_01L3tSFK3P9vGwbNNtb4AYQG