chore(build): stop prettier-formatting tauri-plugin-display-awareness's generated permission files#96
Merged
Conversation
…'s generated permission files `cargo build` regenerates `permissions/autogenerated/reference.md` and `permissions/schemas/schema.json` from the plugin's command definitions, writing them in schemars' raw (non-prettier) style. Since the committed versions were prettier-formatted, every `cargo build` produced a pure-whitespace diff that had to be re-formatted and re-committed by hand — the same drift already solved for `tauri-plugin-spindle-project` via `.prettierignore`, just never extended to this plugin. - Added the equivalent `.prettierignore` entries for `tauri-plugin-display-awareness`'s autogenerated/schemas directories. - Committed the current raw codegen output as the new baseline so future `cargo build` runs produce zero diff (verified by building twice in a row with no further changes). No functional change — diff is pure whitespace/indentation, confirmed by inspection. Verified via: - `cargo build -p tauri-plugin-display-awareness` twice in a row (no further drift) - `cargo test -p tauri-plugin-display-awareness` (9 passed) - `pnpm exec prettier --check .` (clean — no longer flags these files) - `pnpm vitest run` (228 passed, unaffected)
ScottMorris
added
chore
Contributor
Author
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo buildregeneratestauri-plugin-display-awareness'spermissions/autogenerated/reference.mdandpermissions/schemas/schema.jsonin schemars' raw (non-prettier) style, but the committed versions were prettier-formatted — every build produced a pure-whitespace diff that had to be hand-reformatted and recommitted.tauri-plugin-spindle-projectalready solved this exact problem via.prettierignore; this just extends the same fix totauri-plugin-display-awareness.prettierignoreentries and committed the current raw codegen output as the new baseline, verified stable across repeatedcargo buildrunsTest plan
cargo build -p tauri-plugin-display-awarenesstwice in a row — no further driftcargo test -p tauri-plugin-display-awareness(9 passed)pnpm exec prettier --check .(clean)pnpm vitest run(228 passed, unaffected)