Skip to content

Support R8 full mode for lich-viewmodel - #140

Open
ganadist wants to merge 1 commit into
line:masterfrom
ganadist:r8_lich_viewmodel
Open

Support R8 full mode for lich-viewmodel#140
ganadist wants to merge 1 commit into
line:masterfrom
ganadist:r8_lich_viewmodel

Conversation

@ganadist

@ganadist ganadist commented Aug 12, 2026

Copy link
Copy Markdown

We found classes can be merged aggressively on R8 full mode.
This change will help to migrate R8 full mode on android apps which are relied on lich viewmodel.

Test

$ ./gradlew :viewmodel:assembleRelease

$ zipgrep keepnames viewmodel/build/outputs/aar/viewmodel-release.aar
proguard.txt:# -keepnames (= -keep,allowshrinking) only pins the class *name*: it prevents
proguard.txt:-keepnames class * extends com.linecorp.lich.viewmodel.ViewModelFactory

@CLAassistant

CLAassistant commented Aug 12, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants