Add DesignSpaceDocument::load_from_reader#406
Open
cmyr wants to merge 1 commit into
Open
Conversation
This is specifically to support the no-fs use case (wasm, e.g.)
cmyr
force-pushed
the
designspace-from-reader
branch
from
e05f70b to
ab11d0b
Compare
RickyDaMa
reviewed
May 18, 2026
|
|
||
| /// Load a designspace from a reader. | ||
| pub fn load_from_reader( | ||
| reader: impl std::io::BufRead, |
Collaborator
There was a problem hiding this comment.
Is there a reason we constrain on BufRead here, instead of just Read?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is specifically to support the no-fs use case (wasm, e.g.)