Skip to content

feat: recognize rucking activity code 225 - #61

Merged
lingcang728 merged 2 commits into
lingcang728:mainfrom
luispabon:recognize-rucking-code-225
Sep 5, 2026
Merged

feat: recognize rucking activity code 225#61
lingcang728 merged 2 commits into
lingcang728:mainfrom
luispabon:recognize-rucking-code-225

Conversation

@luispabon

@luispabon luispabon commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes:

  • Map Zepp activity code 225 to Rucking (负重徒步).
  • Replay stored workout summaries on direct upgrade from normalizer v22, correcting unknown:225 while preserving user overrides and raw source facts.
  • Add catalog, normalization, replay, frontend label, and changelog coverage.
image

@luispabon
luispabon force-pushed the recognize-rucking-code-225 branch 2 times, most recently from 71b478a to 4f3d81f Compare September 4, 2026 12:45
@luispabon
luispabon marked this pull request as ready for review September 4, 2026 14:24
@lingcang728

lingcang728 commented Sep 4, 2026

Copy link
Copy Markdown
Owner

Thanks! I noticed one upgrade-path issue after approving this.

The latest public release, v2.1.2, still uses zepp-normalizer-2026-09-v21-elliptical. v22-watch-laps only exists on the current unreleased main branch.

So PREVIOUS_RELEASE_NORMALIZER_REVISION should stay at zepp-normalizer-2026-09-v21-elliptical, and PREVIOUS_RELEASE_REPLAY_STREAMS should include both workout_detail and workouts.

Everything else looks good. Once this is adjusted, this should be ready to merge.

lingcang728
lingcang728 requested changes Sep 4, 2026
View reviewed changes

@lingcang728 lingcang728 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for the upgrade-path issue noted in my comment above.

@luispabon

luispabon commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I could wait until the next version is released and rebase against it? That way there'd be no issue. Unless you want this fix on 2.2? I can see you have a PR open for it already

Done as instructed.

@luispabon
luispabon force-pushed the recognize-rucking-code-225 branch from 4f3d81f to 7770d60 Compare September 4, 2026 16:19
@luispabon
feat: recognize rucking activity code 225
b88ccb2 
Map Zepp activity code 225 to Rucking, replay stored workout summaries on upgrade, preserve type overrides, and add catalog, normalization, storage, frontend-label, and changelog coverage.
@luispabon
fix: replay public v21 streams on normalizer upgrade
8ff9350
@luispabon
luispabon force-pushed the recognize-rucking-code-225 branch from 7770d60 to 8ff9350 Compare September 4, 2026 16:19
@lingcang728
lingcang728 merged commit e6234b6 into lingcang728:main Sep 5, 2026
9 checks passed
@lingcang728 lingcang728 mentioned this pull request Sep 5, 2026
Merged
luispabon pushed a commit to luispabon/ZeppBridge that referenced this pull request Sep 5, 2026
@lingcang728 @claude
docs(changelog): 负重徒步记在了 2.1.2 名下，挪回 2.2.0
838da6d 
PR lingcang728#61 的条目锚点对齐到了「英里」那一条，而英里属于 2.1.2——于是负重徒步
被记进了 9 月 3 日就已经发布、根本没有这个功能的那一版，同时 2.2.0 里这个
新增功能一个字都没有。纯位置问题，两行原文一字未改。

发出去的包不受影响：Release 正文和 latest.json 的更新说明都取自附注标签，
不读 CHANGELOG。这条修的是仓库自己的记录。

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lingcang728 lingcang728 lingcang728 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@luispabon @lingcang728