fix(desktop): restore unreachable windows and avoid Windows recovery deadlocks - #65
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A Windows user reports that ZeppBridge initially worked, but subsequent launches leave a tray icon and no accessible app window, including after reinstalling v2.1.2 and v2.2.0. The supplied log reaches background normalizer replay, which confirms database initialization succeeded on those launches. It contains no monitor-sizing, window-open, or fatal-startup diagnostics.
The existing code has a confirmed recovery defect: when
mainis absent, tray and single-instance callbacks build a WebView synchronously. Tauri explicitly documents a Windows deadlock for window creation in synchronous event handlers: https://docs.rs/tauri/2.11.5/tauri/webview/struct.WebviewWindowBuilder.html. Existing-window recovery also ignores window API failures and never repairs off-screen geometry.current_monitor()returningNoneor an error produces no log at all.The supplied log does not prove which path caused this user's original failure. In particular, neither a zero-sized monitor nor a WebView crash is established. This PR fixes the concrete recovery defects and fills the diagnostic gaps needed to verify the affected machine. No private logs or account data are included.
Changes
Validation
npm run build), workspace Rust formatting,git diff --check, and seven executable Rust geometry tests (disconnected displays, negative origins, inaccessible titlebars, normal/maximized windows, zero/tiny sizes, oversized windows, and overflow boundaries).5b22b3497e879acbab8ce6017df931394e2d64fe: Windows, macOS, and Linux all passed full-workspace Rust checking (--all-targets) and Clippy (-D warnings). Windows frontend/function tests also passed. Full Rust test jobs were still running at this update; see the live CI run for the final outcome.No version bump, release publication, authentication changes, or user-data deletion.