fix(cli): make tests OS-agnostic by normalizing path separators #1288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes test failures on Windows by normalizing path separators in test assertions. The tests were failing because Windows uses backslashes while the expected values used forward slashes. The fix ensures tests pass on all operating systems without modifying runtime code.
Key changes:
- Added helper functions to normalize path separators to POSIX-style (forward slashes) in test assertions
- Applied normalization to test results before comparison in buckets.spec.ts and find-locale-paths.spec.ts
- Added changeset documenting the patch fix
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/cli/src/cli/utils/buckets.spec.ts | Added normalizeBuckets helper to convert path separators before assertions |
| packages/cli/src/cli/utils/find-locale-paths.spec.ts | Added normalize helper to convert path separators in patterns and defaultPatterns |
| .changeset/soft-melons-sin.md | Documented patch-level change for CLI path separator fix |
| lingo.dev | Added subproject commit reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "lingo.dev": patch | |||
There was a problem hiding this comment.
The package name in the changeset should be '@lingo.dev/cli' or similar, not 'lingo.dev'. The changeset should reference the actual package being changed (the CLI package), not the root project name.
Suggested change
| "lingo.dev": patch | |
| "@lingo.dev/cli": patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1280
Summary
On Windows, several CLI tests failed due to backslash vs forward slash path separators in expected vs received values. This PR normalizes path strings in test assertions so comparisons are OS-agnostic.
Changes
pathPatternto POSIX-style before equality assertions.Rationale
Path separators differ across OSes. Normalizing in tests ensures consistent behavior across Windows/macOS/Linux without touching runtime code.
Test Plan
Environment: Windows 11, Node v22.19.0, pnpm 9.12.3
Steps:
pnpm installpnpm -C packages/cli testResults:
Optional: See Issue for failure screenshots before this change.
Breaking Changes
None.
Checklist