Remove dead lce_forward_deprecated path from qwen2#1241
Merged
Conversation
lce_forward_deprecated in transformers/model/qwen2.py was the pre- logits_to_keep codepath. It has had zero references in src/, test/, or benchmark/ for some time and the active lce_forward right below it has been the only one wired into the monkey patch. Removing it also drops four imports that only it used (CrossEntropyLoss, CausalLMOutputWithPast, LigerFusedLinearCrossEntropyLoss, and the redundant blank line). Net: -120 LOC, no behavior change.
Mecoli1219
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleaning up lce_forward_deprecated in qwen2.py as it is not being used anywhere.
Testing Done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence