Example UDF and its unit test to repro issue: https://github.com/link…#123
Open
mohit10verma wants to merge 1 commit intolinkedin:masterfrom
Open
Example UDF and its unit test to repro issue: https://github.com/link…#123mohit10verma wants to merge 1 commit intolinkedin:masterfrom
mohit10verma wants to merge 1 commit intolinkedin:masterfrom
Conversation
aastha25
reviewed
Feb 21, 2023
| @Override | ||
| public StdStruct eval(StdStruct myStruct) { | ||
| int currVal = ((StdInteger) myStruct.getField(0)).get(); | ||
| myStruct.setField(0, getStdFactory().createInteger(currVal + 1)); |
Collaborator
There was a problem hiding this comment.
can you try
(using field_name instead of field index) and see if the same issue persists?
Author
There was a problem hiding this comment.
I don't think transport UDFs test framework lets users create structs with named fields. You can try that and let me know if I am mistaken.
Author
There was a problem hiding this comment.
I tried fixing this in a totally different PR here: #119
But this issue is independent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…edin/transport/issues/120
Build the examples folder
transportable-udfs-examplesto see the error after applying this patch.